[devstack] Stopping kuryr-k8s raises exception in watcher.py

[Kirill Zaitsev]

kuryr-kubernetes service in devstack doesn't seem to stop cleanlly. to reproduce: deploy latest devstack (with systemd and kuryr-kubernetes), stop/restart kuryr-kubernetes service `sudo systemctl restart <email address hidden>`, check the logs `journalctl -u <email address hidden>`

observed traceback:

May 19 15:25:27 devstack python[23510]: 2017-05-19 15:25:27.507 23510 INFO kuryr_kubernetes.controller.service [-] Service 'KuryrK8sService' stopping
May 19 15:25:27 devstack python[23510]: Traceback (most recent call last):
May 19 15:25:27 devstack python[23510]: File "/usr/local/lib/python2.7/dist-packages/eventlet/hubs/hub.py", line 457, in fire_timers
May 19 15:25:27 devstack python[23510]: timer()
May 19 15:25:27 devstack python[23510]: File "/usr/local/lib/python2.7/dist-packages/eventlet/hubs/timer.py", line 58, in __call__
May 19 15:25:27 devstack python[23510]: cb(*args, **kw)
May 19 15:25:27 devstack python[23510]: File "/usr/local/lib/python2.7/dist-packages/eventlet/greenthread.py", line 214, in main
May 19 15:25:27 devstack systemd[1]: Stopping Devstack <email address hidden>...
May 19 15:25:27 devstack python[23510]: result = function(*args, **kwargs)
May 19 15:25:27 devstack python[23510]: File "/usr/local/lib/python2.7/dist-packages/oslo_service/service.py", line 178, in _handle_signal_cb
May 19 15:25:27 devstack python[23510]: handler(signo, frame)
May 19 15:25:27 devstack python[23510]: File "/usr/local/lib/python2.7/dist-packages/oslo_service/service.py", line 274, in _graceful_shutdown
May 19 15:25:27 devstack python[23510]: self.stop()
May 19 15:25:27 devstack python[23510]: File "/usr/local/lib/python2.7/dist-packages/oslo_service/service.py", line 228, in stop
May 19 15:25:27 devstack python[23510]: self.services.stop()
May 19 15:25:27 devstack python[23510]: File "/usr/local/lib/python2.7/dist-packages/oslo_service/service.py", line 687, in stop
May 19 15:25:27 devstack python[23510]: service.stop()
May 19 15:25:27 devstack python[23510]: File "/opt/stack/kuryr-kubernetes/kuryr_kubernetes/controller/service.py", line 62, in stop
May 19 15:25:27 devstack python[23510]: self.watcher.stop()
May 19 15:25:27 devstack python[23510]: File "/opt/stack/kuryr-kubernetes/kuryr_kubernetes/watcher.py", line 119, in stop
May 19 15:25:27 devstack python[23510]: self._stop_watch(path)
May 19 15:25:27 devstack python[23510]: File "/opt/stack/kuryr-kubernetes/kuryr_kubernetes/watcher.py", line 133, in _stop_watch
May 19 15:25:27 devstack python[23510]: self._watching[path].kill()
May 19 15:25:27 devstack python[23510]: AttributeError: 'Thread' object has no attribute 'kill'

[janonymous (janonymous)]

I think issue lies here(No kill attribute, instead thread.kill() in stop:
http://git.openstack.org/cgit/openstack/deb-python-oslo.service/tree/oslo_service/threadgroup.py#n53

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/474519

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/474519
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=6e2183f0b697bc24392dc741c68126bc84f00eed
Submitter: Jenkins
Branch: master

commit 6e2183f0b697bc24392dc741c68126bc84f00eed
Author: Janonymous <email address hidden>
Date: Thu Jun 15 09:03:50 2017 +0000

    Stopping Thread from oslo_service

    Change-Id: I51b3db7c0fb7eafcd35f0e4f866b43037c2cbc76
    Closes-bug: #1693140

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kuryr-kubernetes 0.2.0 release.