not all contacts are indexed in Thunderbird

Bug #747538 reported by sojusnik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kupfer
Fix Released
Undecided
Karol Będkowski

Bug Description

It seems that not all contacts from my Thunderbird address book are indexed. All contacts are saved under the default Thunderbird "personal contacts" address book. Altogether, there are 48 contacts in there, but Kupfer indexed only 26. Why?

Is this a bug or a feature?

Revision history for this message
Karol Będkowski (karol-bedkowski) wrote :

Could you give us some more information - which contacts are not loaded. Also please run Kupfer with --debug option and attach log.
Generally Kupfer display only contacts with defined "display name" or first / last name.

Changed in kupfer:
assignee: nobody → Karol Będkowski (karol-bedkowski)
Revision history for this message
sojusnik (sojusnik) wrote :

It seems, that only contacts with a defined "display name" or first / last name are shown, as you said. Therefore I added a last and first name to a existing contact, restarted Ubuntu and waited some time, but the new entered contact is still not appearing in Kupfer.

See log in the attachment.

Revision history for this message
Karol Będkowski (karol-bedkowski) wrote :

Thank you.
Attached patch should solve this problem. Please check.

Changed in kupfer:
status: New → In Progress
Revision history for this message
sojusnik (sojusnik) wrote :

How do I apply this patch?

Revision history for this message
Karol Będkowski (karol-bedkowski) wrote :

Please do this steps:
- save patch in /tmp,
- on console
cd /usr/share/kupfer
sudo patch -p1 < /tmp/thunderbird_lp_747538.patch
- clean up kupfer cache by:
- restart kupfer.

Revision history for this message
sojusnik (sojusnik) wrote :

This patch works. Now also contacts without First/Last/Display name are indexed.

Contacts that were before without First/Last/Display name and the name was added later by me, have 2 entries now. The first is with the displayed name, the second only with the e-mail.

Is this by design?

So this patch will move into a future release of your plugin?

Revision history for this message
sojusnik (sojusnik) wrote :

When I remove a contact from Thunderbird, the contact is still in Kupfer's index. Even after a restart of Kupfer. How long does it take Kupfer to completely remove the deleted entry?

Revision history for this message
X (u78qir8a9-deactivatedaccount) wrote :

The contact should have disappeared almost immediately. Everything is rescanned after a fresh start of kupfer, it takes a minute or so. At the point where it writes:

[kupfer.core.sources] PeriodicRescanner: Campaign finished, pausing 3600 s

then it has refreshed all sources.

Revision history for this message
sojusnik (sojusnik) wrote :

Thanks for answering, but what about that:

Contacts that are without a First/Last/Display name are indexed now, but when I add a First/Last/Display name to them, then 2 entries are shown in Kupfer. The first one is with the e-mail adress without the First/Last/Display name, the second one with the e-mail adress and First/Last/Display name.

Is this by design?

It would be of course better, that it will be updated so that only one entry is shown and not two. Either one with the e-mail adress or if the First/Last/Display name is available, the one with the First/Last/Display name.

And the contacts are not disappearing after 6 minutes, after a restart and so on. The contact is not in my adress book, but it is still in Kupfer.

Revision history for this message
X (u78qir8a9-deactivatedaccount) wrote :

I will let Karol answer everything, I don't know anything about this plugin. :-)

Revision history for this message
Karol Będkowski (karol-bedkowski) wrote :

I found small bug. Attached patch should solve this problems. Please apply it as above.
In normal case, Kupfer don't show duplicated items. But, if you defined two identical contacts in two address books - they will appear twice.
Also this patch solve (I hope) problem with refreshing contacts. But sometimes I see that thunderbird don't flush changes immediately to the disk, so there may be some delay.

Revision history for this message
sojusnik (sojusnik) wrote :

All problems solved! Works like a charm!

Changed in kupfer:
status: In Progress → Fix Committed
Revision history for this message
X (u78qir8a9-deactivatedaccount) wrote :

Not yet committed to the right place. If you mark this fix committed then it's harder for me to find the bug and apply the patches :-)

This patch and the libreoffice patch ready for master karol?

Changed in kupfer:
status: Fix Committed → New
Revision history for this message
Karol Będkowski (karol-bedkowski) wrote :

Both seems to be ready, but I still testing it.
I need one more day...

Revision history for this message
X (u78qir8a9-deactivatedaccount) wrote :

We have some days until the next release, probably will not be before the end of the week. We had a lot of bugfixes as recently as yesterday. The attention we have gotten has made kupfer at least a bit more polished.

Changed in kupfer:
status: New → Fix Committed
Changed in kupfer:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.