[hns-1126]net: hns3: fix interrupt clearing error for VF

Bug #1853974 reported by Fred Kimmy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kunpeng920
Fix Released
Undecided
Unassigned
Ubuntu-18.04
Won't Fix
Undecided
Unassigned
Ubuntu-18.04-hwe
Fix Released
Undecided
Unassigned
Ubuntu-19.04
Won't Fix
Undecided
Unassigned
Ubuntu-19.10
Won't Fix
Undecided
Unassigned
Ubuntu-20.04
Fix Released
Undecided
Unassigned
Upstream-kernel
Fix Released
Undecided
Unassigned

Bug Description

"[Bug Description]
Currently, VF driver has two kinds of interrupts, reset & CMDQ RX.
According to the UM, each interrupt should be cleared by write 0
to the corresponding bit, but the implementation is write 0 to the
whole register in fact, it will clear other interrupt at the same
time, then the VF will loss the interrupt.

[Steps to Reproduce]
1.load PF&VF driver
2.echo ""1"" > /sys/class/net/${LocalNetwork}/device/sriov_numvfs
3.check message by dmesg command

[Actual Results]
Add VF failed

[Expected Results]
Add VF successfullly

[Reproducibility]
Inevitably

[Additional information]
Hardware: D06 ES
Firmware: NA
Kernel: NA

[Resolution]
This patch fixes it, also, adds a new register for reading the interrupt
status according to hardware user manual."

net: hns3: fix interrupt clearing error for VF
net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support
net: hns3: add reset handling for VF when doing Core/Global/IMP reset

Revision history for this message
Ike Panhc (ikepanhc) wrote :

commit 130509213baeb3cada40c19dd87341a6787f8b23
Author: Huazhong Tan <email address hidden>
Date: Fri Aug 9 10:31:08 2019 +0800

    net: hns3: fix interrupt clearing error for VF

This patch fixes

    Fixes: e2cb1dec9779 ("net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support")
    Fixes: b90fcc5bd904 ("net: hns3: add reset handling for VF when doing Core/Global/IMP reset")

which been introduced while v5.0

I will see if we shall backport this fix for v5.3

tags: added: backport
Ike Panhc (ikepanhc)
tags: removed: backport
Ike Panhc (ikepanhc)
tags: added: ikeradar
Revision history for this message
Andrew Cloke (andrew-cloke) wrote :

19.04 is now EOL.

Changed in kunpeng920:
status: New → Triaged
Revision history for this message
Ike Panhc (ikepanhc) wrote :

Can't clean cherry-picked for eoan/master-next.

Changed in kunpeng920:
status: Triaged → Fix Committed
tags: removed: ikeradar
Ike Panhc (ikepanhc)
Changed in kunpeng920:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.