[hns3-0120]pad the short frame before sending to the hardware
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
kunpeng920 |
Fix Released
|
Undecided
|
Unassigned | ||
Ubuntu-18.04 |
Fix Released
|
Undecided
|
Taihsiang Ho | ||
Ubuntu-18.04-hwe |
Fix Released
|
Undecided
|
Taihsiang Ho | ||
Upstream-kernel |
Fix Released
|
Undecided
|
Taihsiang Ho | ||
linux (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Taihsiang Ho |
Bug Description
The hardware can not handle short frames below or equal to 32
bytes.
[Impact]
The system may hang or endless event log in /var/log/syslog
[Fix]
Cherry-pick or backport the upstream fix 36c67349a1a1c88
[Test Case]
Send a frame less than 33 bytes.
[Regression Risk]
Low, the patch is only specific to the hns3 driver.
====== Original Bug Description ======
[Bug Description]
The hardware can not handle short frames below or equal to 32
bytes according to the hardware user manual, and it will trigger
a RAS error when the frame's length is below 33 bytes.
[Steps to Reproduce]
1.send a frame less than 33 bytes.
[Actual Results]
a RAS occurs
[Expected Results]
no RAS
[Reproducibility]
Inevitably
[Additional information]
Hardware: D06
Firmware: NA
Kernel: NA
[Resolution]
pads the SKB when skb->len is below 33 bytes before sending it to hardware.
net: hns3: pad the short frame before sending to the hardware
CVE References
description: | updated |
description: | updated |
Changed in kunpeng920: | |
status: | New → In Progress |
Changed in linux (Ubuntu Bionic): | |
status: | New → In Progress |
assignee: | nobody → Taihsiang Ho (taihsiangho) |
tags: | added: patch |
Changed in linux (Ubuntu Bionic): | |
status: | In Progress → Fix Committed |
status: | Fix Committed → In Progress |
tags: | added: tairadar |
Changed in linux (Ubuntu Bionic): | |
status: | In Progress → Fix Committed |
Changed in kunpeng920: | |
status: | In Progress → Fix Committed |
Changed in kunpeng920: | |
status: | Fix Committed → Fix Released |
tags: | removed: tairadar |
The patch has been in ubuntu focal
commit 0e282454804fc4d 1de2ae6847d292d a6b67f45c1
Author: Yunsheng Lin <email address hidden>
Date: Wed Jan 15 10:46:45 2020 +0800
net: hns3: pad the short frame before sending to the hardware
BugLink: https:/ /bugs.launchpad .net/bugs/ 1861090
[ Upstream commit 36c67349a1a1c88 b9cf11d7ca7762a babdb38867 ]
The hardware can not handle short frames below or equal to 32
bytes according to the hardware user manual, and it will trigger
a RAS error when the frame's length is below 33 bytes.
This patch pads the SKB when skb->len is below 33 bytes before
sending it to hardware.
Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC")
Signed-off-by: Yunsheng Lin <email address hidden>
Signed-off-by: Huazhong Tan <email address hidden>
Signed-off-by: David S. Miller <email address hidden>
Signed-off-by: Greg Kroah-Hartman <email address hidden>
Signed-off-by: Paolo Pisati <email address hidden>