[hns-1126]net: hns3: fixes wrong place enabling ROCE HW error when loading

Bug #1853933 reported by Fred Kimmy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kunpeng920
Fix Released
Undecided
Unassigned
Ubuntu-18.04
Won't Fix
Undecided
Unassigned
Ubuntu-18.04-hwe
Fix Released
Undecided
Unassigned
Ubuntu-19.04
Won't Fix
Undecided
Unassigned
Ubuntu-19.10
Fix Released
Undecided
Unassigned
Upstream-kernel
Fix Released
Undecided
Unassigned

Bug Description

"[Bug Description]
Presently the HNS driver enables the HNS H/W error interrupts after
the dev initialization is completed. However some exceptions such as
NCSI errors can occur when the network port driver is not loaded
and those errors required reporting to the BMC.
Therefore the firmware enabled all the HNS ras error interrupts
before the driver is loaded. And in some cases, there will be some
H/W errors remained unclear before reboot. Thus the HNS driver needs
to process and recover those hw errors occurred before HNS driver is
initialized.

[Steps to Reproduce]
1. enject a error which not need reset
2. load PF driver
3. read HW error status register

[Actual Results]
HW error still exist

[Expected Results]
no HW error after loaded

[Reproducibility]
Inevitably

[Additional information]
Hardware: D06
Firmware: NA
Kernel: NA

[Resolution]
Adds processing of the HNS hw errors(RAS and MSI-X)
which occurred before the driver initialization. For RAS, because
they are enabled by firmware, so we can detect specific bits, then
log and clear them. But for MSI-X which can not be enabled before
open vector0 irq, we can't detect the specific error bits, so we
just write 1 to all interrupt source registers to clear."

net: hns3: fixes wrong place enabling ROCE HW error when loading
net: hns3: add recovery for the H/W errors occurred before the HNS dev initialization
net: hns3: process H/W errors occurred before HNS dev initialization"

Revision history for this message
dann frazier (dannf) wrote :

Each of these commits were introduced upstream in v5.3. v5.3 will be the new HWE base kernel for 18.04.4.

Note that the current SRU cycle is targeted for 18.04.4:
  https://lists.ubuntu.com/archives/kernel-sru-announce/2019-October/000158.html

The "last-commit" date for this cycle was 11-Nov. Since 18.04.4 will switch the HWE kernel from 5.0 to 5.3, backporting these changes to the 5.0 branch would be of no benefit to Ubuntu LTS. Therefore, setting the Ubuntu-18.04-hwe target to Ubuntu-18.04.4.

Changed in kunpeng920:
status: New → Fix Committed
no longer affects: kunpeng920/ubuntu-20.04
Changed in kunpeng920:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.