[hns3-0120]pad the short frame before sending to the hardware
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | kunpeng920 |
Undecided
|
Unassigned | ||
| | Ubuntu-18.04 |
Undecided
|
Taihsiang Ho | ||
| | Ubuntu-18.04-hwe |
Undecided
|
Taihsiang Ho | ||
| | Upstream-kernel |
Undecided
|
Taihsiang Ho | ||
| | linux (Ubuntu) |
Undecided
|
Unassigned | ||
| | Bionic |
Undecided
|
Taihsiang Ho | ||
Bug Description
The hardware can not handle short frames below or equal to 32
bytes.
[Impact]
The system may hang or endless event log in /var/log/syslog
[Fix]
Cherry-pick or backport the upstream fix 36c67349a1a1c88
[Test Case]
Send a frame less than 33 bytes.
[Regression Risk]
Low, the patch is only specific to the hns3 driver.
====== Original Bug Description ======
[Bug Description]
The hardware can not handle short frames below or equal to 32
bytes according to the hardware user manual, and it will trigger
a RAS error when the frame's length is below 33 bytes.
[Steps to Reproduce]
1.send a frame less than 33 bytes.
[Actual Results]
a RAS occurs
[Expected Results]
no RAS
[Reproducibility]
Inevitably
[Additional information]
Hardware: D06
Firmware: NA
Kernel: NA
[Resolution]
pads the SKB when skb->len is below 33 bytes before sending it to hardware.
net: hns3: pad the short frame before sending to the hardware
CVE References
| Taihsiang Ho (taihsiangho) wrote : | #1 |
| Taihsiang Ho (taihsiangho) wrote : | #2 |
The patch has not been in bionic-hwe Ubuntu-
| description: | updated |
| description: | updated |
| Taihsiang Ho (taihsiangho) wrote : | #3 |
The patch backported to 18.04. Verified on d06-2 by sending frames < 33 bytes over raw socket to ethernet interface.
| Changed in kunpeng920: | |
| status: | New → In Progress |
| Changed in linux (Ubuntu Bionic): | |
| status: | New → In Progress |
| assignee: | nobody → Taihsiang Ho (taihsiangho) |
This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:
apport-collect 1860320
and then change the status of the bug to 'Confirmed'.
If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.
This change has been made by an automated script, maintained by the Ubuntu Kernel Team.
| Changed in linux (Ubuntu): | |
| status: | New → Incomplete |
| tags: | added: patch |
| Ike Panhc (ikepanhc) wrote : | #5 |
In focal kernel already.
$ gitoneline origin/master-next | grep 'pad the short frame before sending'
0e282454804f <email address hidden> 2020-01-30 16:26:32 +0100 net: hns3: pad the short frame before sending to the hardware
| Changed in linux (Ubuntu): | |
| status: | Incomplete → Fix Released |
| Taihsiang Ho (taihsiangho) wrote : | #6 |
In eoan kernel already.
$ git log --grep="net: hns3: pad the short frame before sending to the hardware"
commit 39d592aa888b3cf
Author: Yunsheng Lin <email address hidden>
Date: Wed Jan 15 10:46:45 2020 +0800
net: hns3: pad the short frame before sending to the hardware
BugLink: https:/
[ Upstream commit 36c67349a1a1c88
The hardware can not handle short frames below or equal to 32
bytes according to the hardware user manual, and it will trigger
a RAS error when the frame's length is below 33 bytes.
This patch pads the SKB when skb->len is below 33 bytes before
sending it to hardware.
Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC")
Signed-off-by: Yunsheng Lin <email address hidden>
Signed-off-by: Huazhong Tan <email address hidden>
Signed-off-by: David S. Miller <email address hidden>
Signed-off-by: Greg Kroah-Hartman <email address hidden>
Signed-off-by: Kamal Mostafa <email address hidden>
Signed-off-by: Khalid Elmously <email address hidden>
| Changed in linux (Ubuntu Bionic): | |
| status: | In Progress → Fix Committed |
| status: | Fix Committed → In Progress |
| tags: | added: tairadar |
| Taihsiang Ho (taihsiangho) wrote : | #7 |
The patch in Eoan is merged over stable channel https:/
| Taihsiang Ho (taihsiangho) wrote : | #8 |
The fix is expected to land bionic-hwe after this SRU cycle completes
---
bionic-hwe kernel tagged Ubuntu-
$ git remote -v
lp git+ssh:
lp git+ssh:
$ git log lp/hwe --abbrev-commit --pretty=oneline --grep "net: hns3: pad the short frame before sending to the hardware"
39d592aa888b net: hns3: pad the short frame before sending to the hardware
$ git tag --list --contains 39d592aa888b
Ubuntu-
Ubuntu-
Ubuntu-
$ rmadison linux-generic-
linux-
linux-
linux-
linux-
linux-
And
"d06-1 5.3.0-40-generic #32~18.04.1-Ubuntu SMP Mon Feb 3 14:08:05 UTC 2020"
could reproduce this issue. /var/log/syslog will output endless log of message
"Mar 3 15:39:35 d06-1 kernel: [ 6305.142251] hns3 0000:7d:00.2: received event 0x400")
| Taihsiang Ho (taihsiangho) wrote : | #9 |
The fix is expected to hit eoan 5.3 kernel after this SRU completes
$ rmadison -asource linux | grep eoan
linux | 5.3.0-18.19 | eoan | source
linux | 5.3.0-40.32 | eoan-security | source
linux | 5.3.0-40.32 | eoan-updates | source
linux | 5.3.0-42.34 | eoan-proposed | source
$ git log upstream/
39d592aa888b net: hns3: pad the short frame before sending to the hardware
$ git tag --list --contains 39d592aa888b
Ubuntu-
Ubuntu-
Ubuntu-
$ git remote -v
upstream git+ssh://<email address hidden>
upstream git+ssh://<email address hidden>
| Taihsiang Ho (taihsiangho) wrote : | #10 |
Current upstream status has this fix commit
$ git log upstream/master --abbrev-commit --pretty=oneline --grep "net: hns3: pad the short frame before sending to the hardware"
36c67349a1a1 net: hns3: pad the short frame before sending to the hardware
$ git tag --list --contains 36c67349a1a1
v5.5
v5.5-rc7
v5.5.1
v5.5.2
v5.5.3
v5.5.4
v5.5.5
v5.5.6
v5.5.7
v5.6-rc1
v5.6-rc2
v5.6-rc3
v5.6-rc4
$ git remote -v
upstream git://git.
upstream git://git.
| Changed in linux (Ubuntu Bionic): | |
| status: | In Progress → Fix Committed |
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-
If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.
See https:/
| tags: | added: verification-needed-bionic |
| Changed in kunpeng920: | |
| status: | In Progress → Fix Committed |
| Taihsiang Ho (taihsiangho) wrote : | #12 |
Verified and the bug is fixed.
- 4.15.0-92-generic, scobee
- 4.15.0-92-generic, d06-2
| tags: |
added: verification-done-bionic removed: verification-needed-bionic |
| Taihsiang Ho (taihsiangho) wrote : | #13 |
I also verified 18.04-hwe 5.3.0-42-generic #34~18.04.1-Ubuntu fixes this issue ( 5.3.0-40-generic #32~18.04.1-Ubuntu still has this issue). Verified on d06-1.
| Launchpad Janitor (janitor) wrote : | #14 |
This bug was fixed in the package linux - 4.15.0-96.97
---------------
linux (4.15.0-96.97) bionic; urgency=medium
* CVE-2020-8834
- KVM: PPC: Book3S HV: Factor fake-suspend handling out of
kvmppc_
- KVM: PPC: Book3S PR: Move kvmppc_
- KVM: PPC: Book3S PR: Add guest MSR parameter for
kvmppc_
linux (4.15.0-94.95) bionic; urgency=medium
* bionic/linux: 4.15.0-94.95 -proposed tracker (LP: #1868984)
* Missing wireless network interface after kernel 5.3.0-43 upgrade with eoan
(LP: #1868442)
- iwlwifi: mvm: Do not require PHY_SKU NVM section for 3168 devices
linux (4.15.0-93.94) bionic; urgency=medium
* bionic/linux: 4.15.0-93.94 -proposed tracker (LP: #1868764)
* quotactl04 from ubuntu_ltp_syscalls failed with B (LP: #1868665)
- ext4: fix mount failure with quota configured as module
linux (4.15.0-92.93) bionic; urgency=medium
* bionic/linux: 4.15.0-92.93 -proposed tracker (LP: #1867272)
* Packaging resync (LP: #1786013)
- [Packaging] resync getabis
- [Packaging] update helper scripts
* Introduce the new NVIDIA 440 series, and add 5.4 Linux compatibility to the
340 and 390 series (LP: #1854485)
- [Packaging] NVIDIA -- add support for the 435 and the 440 series
* Stop using get_scalar_status command in Dell AIO uart backlight driver
(LP: #1865402)
- SAUCE: platform/x86: dell-uart-
* Bionic update: upstream stable patchset 2020-03-12 (LP: #1867194)
- RDMA/core: Fix locking in ib_uverbs_
- gpio: zynq: Report gpio direction at boot
- arm64: ptrace: nofpsimd: Fail FP/SIMD regset operations
- KVM: arm: Fix DFSR setting for non-LPAE aarch32 guests
- KVM: arm: Make inject_abt32() inject an external abort instead
- mtd: onenand_base: Adjust indentation in onenand_
- mtd: sharpslpart: Fix unsigned comparison to zero
- padata: fix null pointer deref of pd->pinst
- Input: synaptics - switch T470s to RMI4 by default
- Input: synaptics - enable SMBus on ThinkPad L470
- Input: synaptics - remove the LEN0049 dmi id from topbuttonpad list
- ALSA: hda/realtek - Fix silent output on MSI-GL73
- ALSA: usb-audio: Apply sample rate quirk for Audioengine D1
- arm64: cpufeature: Set the FP/SIMD compat HWCAP bits properly
- ALSA: usb-audio: sound: usb: usb true/false for bool return type
- ext4: don't assume that mmp_nodename/
- ext4: fix support for inode sizes > 1024 bytes
- ext4: fix checksum errors with indexed dirs
- ext4: add cond_resched() to ext4_protect_
- ext4: improve explanation of a mount failure caused by a misconfigured
kernel
- Btrfs: fix race between using extent maps and merging them
- btrfs: ref-verify: fix memory leaks
- btrfs: print message when tree-log replay starts
- btrfs: log message when rw remount is attempted with unclean tree-log
- arm64: ssbs: Fix context-switch when SSBS is present on all CPUs
- perf/x86/amd: Add missing L2 misses event spec to AMD Family 17h's ev...
| Changed in linux (Ubuntu Bionic): | |
| status: | Fix Committed → Fix Released |
| Changed in kunpeng920: | |
| status: | Fix Committed → Fix Released |
| tags: | removed: tairadar |
The patch has been in ubuntu focal
commit 0e282454804fc4d
Author: Yunsheng Lin <email address hidden>
Date: Wed Jan 15 10:46:45 2020 +0800
net: hns3: pad the short frame before sending to the hardware
BugLink: https:/
[ Upstream commit 36c67349a1a1c88
The hardware can not handle short frames below or equal to 32
bytes according to the hardware user manual, and it will trigger
a RAS error when the frame's length is below 33 bytes.
This patch pads the SKB when skb->len is below 33 bytes before
sending it to hardware.
Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC")
Signed-off-by: Yunsheng Lin <email address hidden>
Signed-off-by: Huazhong Tan <email address hidden>
Signed-off-by: David S. Miller <email address hidden>
Signed-off-by: Greg Kroah-Hartman <email address hidden>
Signed-off-by: Paolo Pisati <email address hidden>