[hns-1126]net: hns3: make hclge_service use delayed workqueue

Bug #1853964 reported by Fred Kimmy on 2019-11-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kunpeng920
Undecided
Unassigned
Ubuntu-18.04
Undecided
Unassigned
Ubuntu-18.04-hwe
Undecided
Unassigned
Ubuntu-19.10
Undecided
Unassigned
Ubuntu-20.04
Undecided
Unassigned
Upstream-kernel
Undecided
Unassigned

Bug Description

"[Bug Description]
Currently, up/down port process may concurrently operate timer(del_timer_sync/add_timer_on) with setting IRQ affinity, and cause system breaking down.

[Steps to Reproduce]
set misc irp affinity of PF during up/down port by follow script:
while((1))
do
for i in {0..31}; do echo $i > /proc/irq/678/smp_affinity_list; done
done
while((1))
do
ifconfig eth4 down
ifconfig eth4 up
done

[Actual Results]
System break down.
kernel call trace

[Expected Results]
System run normally.

[Reproducibility]
Inevitably

[Additional information]
Hardware: D06
Firmware: NA
Kernel: NA

[Resolution]
This patch uses delayed work instead of using timers to trigger the
hclge_serive."

Ike Panhc (ikepanhc) wrote :

Is this patch the fix?

commit 7be1b9f3e99f6213d053d16ed2438126931d8351
Author: Yunsheng Lin <email address hidden>
Date: Mon Jul 29 10:53:28 2019 +0800

    net: hns3: make hclge_service use delayed workqueue

    Use delayed work instead of using timers to trigger the
    hclge_serive.

    Simplify the code with one less middle function and in order
    to support misc irq affinity.

    Signed-off-by: Yunsheng Lin <email address hidden>
    Reviewed-by: Peng Li <email address hidden>
    Signed-off-by: Huazhong Tan <email address hidden>
    Signed-off-by: David S. Miller <email address hidden>

Changed in kunpeng920:
status: New → Incomplete
Fred Kimmy (kongzizaixian) wrote :

this patch is right

Ike Panhc (ikepanhc) on 2019-12-10
Changed in kunpeng920:
status: Incomplete → New
Ike Panhc (ikepanhc) wrote :

Can not clean cherry-pick to bionic kernel cleanly.

Ike Panhc (ikepanhc) on 2020-01-07
tags: added: ikeradar
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers