[Ubuntu Source] - Nova-Compute Image, missing sysfsutils

[cyrille babon]

* Kolla version : Train (I checked the code in all stable versions and sysfsutils is missing in all)

### When I tried to deploy an openstack with kolla-ansible in source mode with Ubuntu, I noticed problem to mount volume on custom cinder backend (HP 3Par FC, I built a custom Cinder image with the HP3Par client).
After checking Docker files, I noticed an inconsistency on the list of packages for the container nova_compute

### If we use image Type Source with OS type Ubuntu, Nova-compute does not have sysfsutils package (and probably other package?).

In Dockerfile.j2, sysfsutils package is missing from the list for Source type and deb :

        {% set nova_compute_packages = [
            'ceph-common',
            'dosfstools',
            'e2fsprogs',
            'genisoimage',
            'libosinfo-bin',
            'multipath-tools',
            'nfs-common',
            'open-iscsi',
            'parted',
            'python3-cephfs',
            'python3-guestfs',
            'python3-libvirt',
            'python3-rados',
            'python3-rbd',
            'python3-rtslib-fb',
            'qemu-utils',
            'targetcli-fb',
            'xfsprogs'
        ] %}

If we Compare with list (in same file) for Binary type and deb :

        {% set nova_compute_packages = [
            'ceph-common',
            'e2fsprogs',
            'genisoimage',
            'ironic-common',
            'multipath-tools',
            'nfs-common',
            'nova-compute',
            'openvswitch-switch',
            'open-iscsi',
            'parted',
            'python3-cephfs',
            'python3-guestfs',
            'python3-ironicclient',
            'python3-oslo.vmware',
            'python3-rados',
            'python3-rbd',
            'python3-rtslib-fb',
            'sysfsutils',
            'targetcli-fb',
            'xfsprogs'
        ] %}

### I built an image by adding sysfsutils and everything is ok for mounting volume cinder on an instance

*How to reproduce it : Create Openstack environment with Kolla (mode Source and OS Ubuntu), and use custom Backend (FC or ISCSI).

[Radosław Piliszek (yoctozepto)]

It could be a problem with FC, since we are testing iSCSI and it seems to be running fine. Obviously it's not that easy to test FC in an IP-only virtual environment. :-)

[Mark Goddard (mgoddard)]

Hi Cyrille, are you planning to propose a fix for this?

[Radosław Piliszek (yoctozepto)]

Is there any indication in the nova-compute logs about that failure?

[Radosław Piliszek (yoctozepto)]

I confirmed the FC Cinder backend requires sysfsutils to work.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/737238

[cyrille babon (cyrille-babon)]

Thx Radosław, you write fix before me :).
All is ok with this fix in my environment.

[Radosław Piliszek (yoctozepto)]

OK, I just asked for the error message so that folks are quicker to find the bug report then.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/737238
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=0c8702c96f852eae7a1fb784a260c01c15fb86f3
Submitter: Zuul
Branch: master

commit 0c8702c96f852eae7a1fb784a260c01c15fb86f3
Author: Radosław Piliszek <email address hidden>
Date: Mon Jun 22 11:05:32 2020 +0200

    Add sysfsutils to nova-compute ubuntu source

    This fixes the FC Cinder backend usage in Nova.

    Change-Id: I036cfe3af3dd96625f986a820c78a10e6558b086
    Closes-bug: #1884484

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/758051

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/758052

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/758053

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/758051
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=de7f3c25918439a97a9ab20b6135327938e74ca1
Submitter: Zuul
Branch: stable/ussuri

commit de7f3c25918439a97a9ab20b6135327938e74ca1
Author: Radosław Piliszek <email address hidden>
Date: Mon Jun 22 11:05:32 2020 +0200

    Add sysfsutils to nova-compute ubuntu source

    This fixes the FC Cinder backend usage in Nova.

    Change-Id: I036cfe3af3dd96625f986a820c78a10e6558b086
    Closes-bug: #1884484
    (cherry picked from commit 0c8702c96f852eae7a1fb784a260c01c15fb86f3)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/758052
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=b38ed5d9f1925a3c5dd24c154e66f4dd22d0f9e2
Submitter: Zuul
Branch: stable/train

commit b38ed5d9f1925a3c5dd24c154e66f4dd22d0f9e2
Author: Radosław Piliszek <email address hidden>
Date: Mon Jun 22 11:05:32 2020 +0200

    Add sysfsutils to nova-compute ubuntu source

    This fixes the FC Cinder backend usage in Nova.

    Change-Id: I036cfe3af3dd96625f986a820c78a10e6558b086
    Closes-bug: #1884484
    (cherry picked from commit 0c8702c96f852eae7a1fb784a260c01c15fb86f3)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/758053
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=28df01a8b55370bd512aedbef685e12aaaa4b4b0
Submitter: Zuul
Branch: stable/stein

commit 28df01a8b55370bd512aedbef685e12aaaa4b4b0
Author: Radosław Piliszek <email address hidden>
Date: Mon Jun 22 11:05:32 2020 +0200

    Add sysfsutils to nova-compute ubuntu source

    This fixes the FC Cinder backend usage in Nova.

    Change-Id: I036cfe3af3dd96625f986a820c78a10e6558b086
    Closes-bug: #1884484
    (cherry picked from commit 0c8702c96f852eae7a1fb784a260c01c15fb86f3)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla 8.0.5 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla 9.3.0 release.