kolla

cannot customise kolla_toolbox_pip_virtualenv_package

  1. Series train
  2. Bug #1865119
Bug #1865119 reported by Xing Zhang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Medium
Radosław Piliszek
kolla 10.0.0 "ussuri"
Rocky
Fix Committed
Medium
Radosław Piliszek
Stein
Fix Committed
Medium
Radosław Piliszek
Train
Fix Committed
Medium
Radosław Piliszek
Ussuri
Fix Released
Medium
Radosław Piliszek
kolla 10.0.0 "ussuri"

Bug Description

According to the doc[1], we can customize dockerfile from template override.

But kolla_toolbox_pip_virtualenv_package[2] can't work in this way. The parameter in customizable filter is the same as kolla_toolbox_pip_packages, and the filter won't work properly.

https://docs.openstack.org/kolla/latest/admin/image-building.html#dockerfile-customisation

https://github.com/openstack/kolla/blob/1e4cf4517165b4e6bca1a84e837dccbd10a33686/docker/kolla-toolbox/Dockerfile.j2#L71-L76

Xing Zhang (xingzhang)
Changed in kolla:
assignee: nobody → Xing Zhang (xingzhang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.opendev.org/710405

Changed in kolla:
status: New → In Progress
Mark Goddard (mgoddard)
Changed in kolla:
importance: Undecided → Medium
Revision history for this message
Mark Goddard (mgoddard) wrote :

Workaround: use kolla_toolbox_pip_packages_*

OpenStack Infra (hudson-openstack)
Changed in kolla:
assignee: Xing Zhang (xingzhang) → Radosław Piliszek (yoctozepto)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.opendev.org/710405
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=74d5a66e6bf744ad936d702443a8d64be86441ba
Submitter: Zuul
Branch: master

commit 74d5a66e6bf744ad936d702443a8d64be86441ba
Author: Xing Zhang <email address hidden>
Date: Fri Feb 28 15:11:30 2020 +0800

    Fix kolla_toolbox_pip_virtualenv_packages override

    backport: train, stein, rocky

    Override in filter needs to follow the rule:
    <image_name>_<call_type>_<override/append/remove>
    `call_type` for `kolla_toolbox_pip_virtualenv_packages` should be
    `pip_virtualenv_packages`, and `pip_packages` can't match with
    `kolla_toolbox_pip_virtualenv_packages`, this makes
    the value can't be overrode in template override.

    Change-Id: I1dbe2dfd4bce73ce2285f45f997d45b5dcc95f4c
    Closes-bug: #1865119

Changed in kolla:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/710495

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/710497

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/710498

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/train)

Reviewed: https://review.opendev.org/710495
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=92ef9274e3a651e6fc2d6d2f0b2a8b00672a246a
Submitter: Zuul
Branch: stable/train

commit 92ef9274e3a651e6fc2d6d2f0b2a8b00672a246a
Author: Xing Zhang <email address hidden>
Date: Fri Feb 28 15:11:30 2020 +0800

    Fix kolla_toolbox_pip_virtualenv_packages override

    backport: train, stein, rocky

    Override in filter needs to follow the rule:
    <image_name>_<call_type>_<override/append/remove>
    `call_type` for `kolla_toolbox_pip_virtualenv_packages` should be
    `pip_virtualenv_packages`, and `pip_packages` can't match with
    `kolla_toolbox_pip_virtualenv_packages`, this makes
    the value can't be overrode in template override.

    Change-Id: I1dbe2dfd4bce73ce2285f45f997d45b5dcc95f4c
    Closes-bug: #1865119
    (cherry picked from commit 74d5a66e6bf744ad936d702443a8d64be86441ba)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/stein)

Reviewed: https://review.opendev.org/710497
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=d53ead9421a288137fba8e20b22844d1cdce6506
Submitter: Zuul
Branch: stable/stein

commit d53ead9421a288137fba8e20b22844d1cdce6506
Author: Xing Zhang <email address hidden>
Date: Fri Feb 28 15:11:30 2020 +0800

    Fix kolla_toolbox_pip_virtualenv_packages override

    backport: train, stein, rocky

    Override in filter needs to follow the rule:
    <image_name>_<call_type>_<override/append/remove>
    `call_type` for `kolla_toolbox_pip_virtualenv_packages` should be
    `pip_virtualenv_packages`, and `pip_packages` can't match with
    `kolla_toolbox_pip_virtualenv_packages`, this makes
    the value can't be overrode in template override.

    Change-Id: I1dbe2dfd4bce73ce2285f45f997d45b5dcc95f4c
    Closes-bug: #1865119
    (cherry picked from commit 74d5a66e6bf744ad936d702443a8d64be86441ba)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/rocky)

Reviewed: https://review.opendev.org/710498
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=da5429cc060c4cfee47f4c7dbe871c9f1328ef3c
Submitter: Zuul
Branch: stable/rocky

commit da5429cc060c4cfee47f4c7dbe871c9f1328ef3c
Author: Xing Zhang <email address hidden>
Date: Fri Feb 28 15:11:30 2020 +0800

    Fix kolla_toolbox_pip_virtualenv_packages override

    backport: train, stein, rocky

    Override in filter needs to follow the rule:
    <image_name>_<call_type>_<override/append/remove>
    `call_type` for `kolla_toolbox_pip_virtualenv_packages` should be
    `pip_virtualenv_packages`, and `pip_packages` can't match with
    `kolla_toolbox_pip_virtualenv_packages`, this makes
    the value can't be overrode in template override.

    Change-Id: I1dbe2dfd4bce73ce2285f45f997d45b5dcc95f4c
    Closes-bug: #1865119
    (cherry picked from commit 74d5a66e6bf744ad936d702443a8d64be86441ba)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 7.1.1

This issue was fixed in the openstack/kolla 7.1.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.