swift containers missing rsync RPM package

[RJ]

Hello. I ran into the following error after deploying Swift via Kolla Ansible 2023.2:

```
2024-03-28T03:19:40-07:00 syslog.local0.err {"Payload":"swift-account-replicator: ERROR syncing /srv/node/d2/accounts/410/08b/669f1f0ee029dfeeb38cc1939119608b/669f1f0ee029dfeeb38cc1939119608b.db with node {'device': 'd0', 'id': 0, 'ip': '10.0.1.2', 'meta': '', 'port': 6001, 'region': 1, 'replication_ip': '10.0.1.2', 'replication_port': 6001, 'weight': 1.0, 'zone': 1, 'index': 2}: #012Traceback (most recent call last):#012 File \"/var/lib/kolla/venv/lib64/python3.9/site-packages/swift/common/db_replicator.py\", line 675, in _replicate_object#012 success = self._repl_to_node(node, broker, partition, info,#012 File \"/var/lib/kolla/venv/lib64/python3.9/site-packages/swift/common/db_replicator.py\", line 481, in _repl_to_node#012 return self._handle_sync_response(node, response, info, broker, http,#012 File \"/var/lib/kolla/venv/lib64/python3.9/site-packages/swift/common/db_replicator.py\", line 489, in _handle_sync_response#012 return self._rsync_db(broker, node, http, info['id'],#012 File \"/var/lib/kolla/venv/lib64/python3.9/site-packages/swift/common/db_replicator.py\", line 333, in _rsync_db#012 if not self._rsync_file(broker.db_file, remote_file,#012 File \"/var/lib/kolla/venv/lib64/python3.9/site-packages/swift/common/db_replicator.py\", line 307, in _rsync_file#012 proc = subprocess.Popen(popen_args)#012 File \"/var/lib/kolla/venv/lib64/python3.9/site-packages/eventlet/green/subprocess.py\", line 58, in __init__#012 subprocess_orig.Popen.__init__(self, args, 0, *argss, **kwds)#012 File \"/usr/lib64/python3.9/subprocess.py\", line 951, in __init__#012 self._execute_child(args, executable, preexec_fn, close_fds,#012 File \"/usr/lib64/python3.9/subprocess.py\", line 1837, in _execute_child#012 raise child_exception_type(errno_num, err_msg, err_filename)#012FileNotFoundError: [Errno 2] No such file or directory: 'rsync'\u0000","log_level":"err","Hostname":"openstack.mydomain.tld","programname":"swift"}
```

Seems to indicate that rsync is missing from the `swift_account_replicator` container. I have confirmed that the binary is at least missing from all of the `*_replicator` containers, which I assume should all have rsync available.

Looking at the Kolla code base, it appears that rsync is intended to be installed in `swift-base`, but the package is missing for RPM distros:

``` title="kolla/docker/swift/swift-base/Dockerfile.j2"
{% if base_package_type == 'rpm' %}
    {% set swift_base_packages = [
        'liberasurecode-devel',
        'nmap-ncat',
    ] %}
{% elif base_package_type == 'deb' %}
    {% set swift_base_packages = [
        'liberasurecode-dev',
        'netcat-openbsd',
        'rsync',
    ] %}
{% endif %}
```

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kolla/+/916489

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla/+/916489
Committed: https://opendev.org/openstack/kolla/commit/7766abb4398d13355a3f76bc1b91f6c92d36111b
Submitter: "Zuul (22348)"
Branch: master

commit 7766abb4398d13355a3f76bc1b91f6c92d36111b
Author: Sven Kieske <email address hidden>
Date: Fri Apr 19 17:04:22 2024 +0200

    swift-base: fix rsync missing for rpm installs

    Closes-Bug: 2062072

    Change-Id: Id6e4bbe0aab2360c4e7e5f74fff6170bcc71080b
    Signed-off-by: Sven Kieske <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/kolla/+/916770

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/kolla/+/916771

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/kolla/+/916772

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: unmaintained/yoga
Review: https://review.opendev.org/c/openstack/kolla/+/916912

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/zed
Review: https://review.opendev.org/c/openstack/kolla/+/916772
Reason: stable/zed branch of openstack/kolla is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/zed if you want to further work on this patch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: unmaintained/zed
Review: https://review.opendev.org/c/openstack/kolla/+/917729

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla 18.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla/+/916912
Committed: https://opendev.org/openstack/kolla/commit/306b51ee68a0fa5cfc026c9fef3586b255f6f92d
Submitter: "Zuul (22348)"
Branch: unmaintained/yoga

commit 306b51ee68a0fa5cfc026c9fef3586b255f6f92d
Author: Sven Kieske <email address hidden>
Date: Fri Apr 19 17:04:22 2024 +0200

    swift-base: fix rsync missing for rpm installs

    Closes-Bug: 2062072

    Change-Id: Id6e4bbe0aab2360c4e7e5f74fff6170bcc71080b
    Signed-off-by: Sven Kieske <email address hidden>
    (cherry picked from commit 7766abb4398d13355a3f76bc1b91f6c92d36111b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla/+/917729
Committed: https://opendev.org/openstack/kolla/commit/e5d79ba457695ec8799bf613e0eca484813af4b4
Submitter: "Zuul (22348)"
Branch: unmaintained/zed

commit e5d79ba457695ec8799bf613e0eca484813af4b4
Author: Sven Kieske <email address hidden>
Date: Fri Apr 19 17:04:22 2024 +0200

    swift-base: fix rsync missing for rpm installs

    Closes-Bug: 2062072

    Change-Id: Id6e4bbe0aab2360c4e7e5f74fff6170bcc71080b
    Signed-off-by: Sven Kieske <email address hidden>
    (cherry picked from commit 7766abb4398d13355a3f76bc1b91f6c92d36111b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla/+/916771
Committed: https://opendev.org/openstack/kolla/commit/c0f6339a4ac85814dfd16fa623f898526342f77d
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit c0f6339a4ac85814dfd16fa623f898526342f77d
Author: Sven Kieske <email address hidden>
Date: Fri Apr 19 17:04:22 2024 +0200

    swift-base: fix rsync missing for rpm installs

    Closes-Bug: 2062072

    Change-Id: Id6e4bbe0aab2360c4e7e5f74fff6170bcc71080b
    Signed-off-by: Sven Kieske <email address hidden>
    (cherry picked from commit 7766abb4398d13355a3f76bc1b91f6c92d36111b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla/+/916770
Committed: https://opendev.org/openstack/kolla/commit/2c0f1b56aa0db89279786c7291b8f5289460c607
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 2c0f1b56aa0db89279786c7291b8f5289460c607
Author: Sven Kieske <email address hidden>
Date: Fri Apr 19 17:04:22 2024 +0200

    swift-base: fix rsync missing for rpm installs

    Closes-Bug: 2062072

    Change-Id: Id6e4bbe0aab2360c4e7e5f74fff6170bcc71080b
    Signed-off-by: Sven Kieske <email address hidden>
    (cherry picked from commit 7766abb4398d13355a3f76bc1b91f6c92d36111b)