Description
===========
kolla sets file permissions at _set_properties() method, but no logs are emitted here.
https://github.com/openstack/kolla/blob/master/docker/base/set_configs.py#L93
~~~
def _merge_directories(self, source, dest):
if os.path.isdir(source):
if os.path.lexists(dest) and not os.path.isdir(dest):
self._delete_path(dest)
if not os.path.isdir(dest):
LOG.info('Creating directory %s', dest)
os.makedirs(dest)
self._set_properties(source, dest)
~~~
If the target file/directory already exist, kolla only copy permissions, but there will be no logs about the target file/directory
This issue can make it difficult to investigate the cause of issues which are caused by setting permissions.
For example, the following bug was caused by copying permissions from /var/lib/config-data/puppet-generated/keystone/etc/openldap to /etc/openldap, but investigation was difficult because _set_properties() doesn't emit any logs.
https://bugs.launchpad.net/tripleo/+bug/1960781
How to reproduce it (minimal and precise):
==================
Run a container which contains kolla.
Then look at "podman/docker logs <container>"
Expected result
===============
Log messages are emitted when kolla tries to set file permissions like the example below
~~~
2022-02-14T12:23:55.396940406+09:00 stderr F INFO:__main__:Creating directory /etc/my.cnf.d
2022-02-14T12:23:55.396940406+09:00 stderr F INFO:__main__:Copying permissions /var/lib/kolla/config_files/src/etc/my.cnf.d to /etc/my.cnf.d
2022-02-14T12:23:25.397103106+09:00 stderr F INFO:__main__:Copying /var/lib/kolla/config_files/src/etc/my.cnf.d/tripleo.cnf to /etc/my.cnf.d/tripleo.cnf
2022-02-14T12:23:55.397940406+09:00 stderr F INFO:__main__:Copying permissions /var/lib/kolla/config_files/src/etc/my.cnf.d/tripleo.cnf to /etc/my.cnf.d/tripleo.cnf
2022-02-14T12:23:55.397940406+09:00 stderr F INFO:__main__:Copying permissions /var/lib/config-data/puppet-generated/keystone/etc/openldap to /etc/openldap
~~~
Actual result
=============
a log message is emitted when kolla tries to set file permissions.
~~~
2022-02-14T12:23:55.396940406+09:00 stderr F INFO:__main__:Creating directory /etc/my.cnf.d
2022-02-14T12:23:25.397103106+09:00 stderr F INFO:__main__:Copying /var/lib/kolla/config_files/src/etc/my.cnf.d/tripleo.cnf to /etc/my.cnf.d/tripleo.cnf
~~~
Environment
===========
this issue was found in a stable-train-based deployment (RHOSP16.1)
Logs & Configs
==============
Nothing
Fix proposed to branch: master
Review: https:/