remote_apt_keys variable in base image should be base_remote_apt_keys for consistency

Bug #1955565 reported by Maksim Malchuk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Invalid
Wishlist
Unassigned

Bug Description

The customization format of the variable name should contain the
<image_name> [1]. The name of the 'remote_apt_keys' variable [2]
incorrect, so customization is ignored.

1. https://docs.openstack.org/kolla/latest/admin/image-building.html#dockerfile-customisation
2. https://opendev.org/openstack/kolla/src/commit/c8da82967946d5252c557c20423684bed383c228/docker/base/Dockerfile.j2#L335

Changed in kolla:
status: New → In Progress
Changed in kolla:
assignee: nobody → Maksim Malchuk (mmalchuk)
description: updated
description: updated
Revision history for this message
Mark Goddard (mgoddard) wrote :

While the variable name is inconsistent and confusing, this is not the part that the code checks.

Changed in kolla:
status: In Progress → Invalid
Revision history for this message
Maksim Malchuk (mmalchuk) wrote :

The variable name should be in the correct format to be overriden. The code of the filter is here: https://opendev.org/openstack/kolla/src/commit/c8da82967946d5252c557c20423684bed383c228/kolla/template/filters.py#L20-L36

Changed in kolla:
status: Invalid → In Progress
Revision history for this message
Mark Goddard (mgoddard) wrote :

As discussed - the override will work regardless of the variable name.

summary: - Customization of remote_apt_keys ignored
+ remote_apt_keys variable in base image should be base_remote_apt_keys
+ for consistenct
summary: remote_apt_keys variable in base image should be base_remote_apt_keys
- for consistenct
+ for consistency
Changed in kolla:
importance: Undecided → Low
Changed in kolla:
status: In Progress → Invalid
assignee: Maksim Malchuk (mmalchuk) → nobody
importance: Low → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.