kolla_set_configs --check fails for non-unicode files

[Radosław Piliszek]

Non-unicode files (especially binary ones) might trigger Unicode decoding errors when trying to compare file contents.

Example failure:

'Traceback (most recent call last):\n File "/tmp/ansible_kolla_docker_payload_4lbmc5u7/ansible_kolla_docker_payload.zip/ansible/modules/kolla_docker.py", line 1176, in main\n File "/tmp/ansible_kolla_docker_payload_4lbmc5u7/ansible_kolla_docker_payload.zip/ansible/modules/kolla_docker.py", line 338, in compare_container\n File "/tmp/ansible_kolla_docker_payload_4lbmc5u7/ansible_kolla_docker_payload.zip/ansible/modules/kolla_docker.py", line 603, in compare_config\nException: Failed to compare container configuration: b\'INFO:__main__:Loading config file at /var/lib/kolla/config_files/config.json\\nINFO:__main__:Validating config file\\nERROR:__main__:Unexpected error:\\nTraceback (most recent call last):\\n File "/usr/local/bin/kolla_set_configs", line 424, in main\\n execute_config_check(config)\\n File "/usr/local/bin/kolla_set_configs", line 410, in execute_config_check\\n config_file.check()\\n File "/usr/local/bin/kolla_set_configs", line 231, in check\\n elif not self._cmp_file(source, dest):\\n File "/usr/local/bin/kolla_set_configs", line 168, in _cmp_file\\n if f1.read() != f2.read():\\n File "/usr/lib64/python3.6/codecs.py", line 321, in decode\\n (result, consumed) = self._buffer_decode(data, self.errors, final)\\nUnicodeDecodeError: \\\'utf-8\\\' codec can\\\'t decode byte 0xea in position 2: invalid continuation byte\\n\'\n'

[Radosław Piliszek (yoctozepto)]

Patch:
https://review.opendev.org/c/openstack/kolla/+/773257

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla 12.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla 10.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla 11.1.0 release.