Invalid test in cinder-api/extend_start.sh

[Gauvain Pocentek]

The data migration script in cinder-api/extend_start.sh uses an incorrect test, leading to an invalid command being run. The current test is:

    if [[ -z ${MAX_NUMBER} ]]; then
        cinder-manage db online_data_migrations --max_count ${MAX_NUMBER}
    else
        cinder-manage db online_data_migrations
    fi

It should be something like:

    if [[ -n ${MAX_NUMBER} ]]; then
        cinder-manage db online_data_migrations --max_count ${MAX_NUMBER}
    else
        cinder-manage db online_data_migrations
    fi

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/712055

[Mark Goddard (mgoddard)]

What command gets run? In what environment does this happen?

[Gauvain Pocentek (gpocentek)]

if MAX_NUMBER is not defined it will run "cinder-manage db online_data_migrations --max_count", which is invalid.

I'm using the containers without kolla-ansible, and I'm not setting the MAX_NUMBER variable. This happens on stein for centos-binary containers, but looking at the stable branches and master it is probably happening everywhere.

From what I've seen kolla-ansible always defines the MAX_NUMBER variable but I don't think it's actually used with that test.

[Mark Goddard (mgoddard)]

Thanks for clarifying - makes sense.

[Dincer Celik (dincercelik)]

@Mark,

I confirm we always run "cinder-manage db online_data_migrations" now although we set the MAX_NUMBER. This change fixes this to "cinder-manage db online_data_migrations --max_count 10".

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/712055
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=ff42ff20048ef3b7d2f8df04ada8ff4bf7b710e0
Submitter: Zuul
Branch: master

commit ff42ff20048ef3b7d2f8df04ada8ff4bf7b710e0
Author: Gauvain Pocentek <email address hidden>
Date: Tue Mar 10 12:46:17 2020 +0100

    Fix invalid test in cinder data migration script

    The extend_start.sh script for cinder-api uses an incorrect test to
    check if the MAX_NUMBER variable is set. This leads to a incorrect
    cinder-manage command being run if this variable is not set, making the
    database migration fail.

    This change fixes the test to properly use the MAX_NUMBER variable.

    Change-Id: Ie46da709db0de09a9cf641b3c154275282f213fc
    Closes-Bug: #1866827

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/715162

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/715163

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/715163
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=4696fc0f322bdc4327b0ac4ec58f2ddc9d014ec1
Submitter: Zuul
Branch: stable/stein

commit 4696fc0f322bdc4327b0ac4ec58f2ddc9d014ec1
Author: Gauvain Pocentek <email address hidden>
Date: Tue Mar 10 12:46:17 2020 +0100

    Fix invalid test in cinder data migration script

    The extend_start.sh script for cinder-api uses an incorrect test to
    check if the MAX_NUMBER variable is set. This leads to a incorrect
    cinder-manage command being run if this variable is not set, making the
    database migration fail.

    This change fixes the test to properly use the MAX_NUMBER variable.

    Change-Id: Ie46da709db0de09a9cf641b3c154275282f213fc
    Closes-Bug: #1866827
    (cherry picked from commit ff42ff20048ef3b7d2f8df04ada8ff4bf7b710e0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/715162
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=60bbf85aa20cc38218123fb6fb7521268e3ac0f6
Submitter: Zuul
Branch: stable/train

commit 60bbf85aa20cc38218123fb6fb7521268e3ac0f6
Author: Gauvain Pocentek <email address hidden>
Date: Tue Mar 10 12:46:17 2020 +0100

    Fix invalid test in cinder data migration script

    The extend_start.sh script for cinder-api uses an incorrect test to
    check if the MAX_NUMBER variable is set. This leads to a incorrect
    cinder-manage command being run if this variable is not set, making the
    database migration fail.

    This change fixes the test to properly use the MAX_NUMBER variable.

    Change-Id: Ie46da709db0de09a9cf641b3c154275282f213fc
    Closes-Bug: #1866827
    (cherry picked from commit ff42ff20048ef3b7d2f8df04ada8ff4bf7b710e0)