kolla

Pushing to registy ignores errors

Bug #1848019 reported by Marcin Juszkiewicz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Medium
Unassigned
kolla 9.0.0 "Train"
Queens
New
Medium
Unassigned
kolla 6.2.5 "queens"
Rocky
Fix Committed
Medium
Radosław Piliszek
kolla 7.1.0 "rocky"
Stein
Fix Committed
Medium
Radosław Piliszek
kolla 8.0.2 "stein"
Train
Fix Released
Medium
Unassigned
kolla 9.0.0 "Train"

Bug Description

If pushing to registry is enabled then Kolla ignores errors and assumes that everything went fine:

INFO:kolla.common.utils.aodh-api:Trying to push the image
ERROR:kolla.common.utils.aodh-api:Get http://10.101.16.1:5000/v2/: dial tcp 10.101.16.1:5000: connect: no route to host
INFO:kolla.common.utils.aodh-api:Pushed successfully

Easiest way to test is adding " --push --registry any.address.which.does.not.resolve:8434 " to kolla-build command.

OpenStack Infra (hudson-openstack)
Changed in kolla:
assignee: nobody → Marcin Juszkiewicz (hrw)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.opendev.org/688390
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=52cac09d3d0b8dcdbc8d68a0bcc8092008220309
Submitter: Zuul
Branch: master

commit 52cac09d3d0b8dcdbc8d68a0bcc8092008220309
Author: Marcin Juszkiewicz <email address hidden>
Date: Mon Oct 14 04:36:48 2019 -0700

    handle push error properly

    If there was some error during pushing then Kolla was greeting with "all went
    fine" message anyway:

    INFO:kolla.common.utils.aodh-api:Trying to push the image
    ERROR:kolla.common.utils.aodh-api:Get http://10.101.16.1:5000/v2/: dial tcp 10.101.16.1:5000: connect: no route to host
    INFO:kolla.common.utils.aodh-api:Pushed successfully

    This patch changes that. Now if there is an error during push then proper
    exception is raised to PushTask and image is marked with PUSH_ERROR status.

    This way at the end of build it is easy to spot which images did not got
    pushed to registry:

    INFO:kolla.common.utils:===========================
    INFO:kolla.common.utils:Images that failed to build
    INFO:kolla.common.utils:===========================
    ERROR:kolla.common.utils:base Failed with status: push_error
    ERROR:kolla.common.utils:nova-api Failed with status: push_error
    ERROR:kolla.common.utils:nova-base Failed with status: push_error
    ERROR:kolla.common.utils:nova-compute Failed with status: push_error
    ERROR:kolla.common.utils:nova-compute-ironic Failed with status: push_error
    ERROR:kolla.common.utils:nova-conductor Failed with status: push_error

    Closes-Bug: #1848019
    Change-Id: Id2ab97bf4c0dc3423268a0ea435b56f4a65f7196

Changed in kolla:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/688897

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/688898

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/rocky)

Reviewed: https://review.opendev.org/688898
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=40d4d12b219806dc8452c7d7dfcedb77c7d452c5
Submitter: Zuul
Branch: stable/rocky

commit 40d4d12b219806dc8452c7d7dfcedb77c7d452c5
Author: Marcin Juszkiewicz <email address hidden>
Date: Mon Oct 14 04:36:48 2019 -0700

    handle push error properly

    If there was some error during pushing then Kolla was greeting with "all went
    fine" message anyway:

    INFO:kolla.common.utils.aodh-api:Trying to push the image
    ERROR:kolla.common.utils.aodh-api:Get http://10.101.16.1:5000/v2/: dial tcp 10.101.16.1:5000: connect: no route to host
    INFO:kolla.common.utils.aodh-api:Pushed successfully

    This patch changes that. Now if there is an error during push then proper
    exception is raised to PushTask and image is marked with PUSH_ERROR status.

    This way at the end of build it is easy to spot which images did not got
    pushed to registry:

    INFO:kolla.common.utils:===========================
    INFO:kolla.common.utils:Images that failed to build
    INFO:kolla.common.utils:===========================
    ERROR:kolla.common.utils:base Failed with status: push_error
    ERROR:kolla.common.utils:nova-api Failed with status: push_error
    ERROR:kolla.common.utils:nova-base Failed with status: push_error
    ERROR:kolla.common.utils:nova-compute Failed with status: push_error
    ERROR:kolla.common.utils:nova-compute-ironic Failed with status: push_error
    ERROR:kolla.common.utils:nova-conductor Failed with status: push_error

    Closes-Bug: #1848019
    Change-Id: Id2ab97bf4c0dc3423268a0ea435b56f4a65f7196
    (cherry picked from commit 52cac09d3d0b8dcdbc8d68a0bcc8092008220309)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/stein)

Reviewed: https://review.opendev.org/688897
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=d6f46d544fd757fdc811d738422f85e64a6dc09b
Submitter: Zuul
Branch: stable/stein

commit d6f46d544fd757fdc811d738422f85e64a6dc09b
Author: Marcin Juszkiewicz <email address hidden>
Date: Mon Oct 14 04:36:48 2019 -0700

    handle push error properly

    If there was some error during pushing then Kolla was greeting with "all went
    fine" message anyway:

    INFO:kolla.common.utils.aodh-api:Trying to push the image
    ERROR:kolla.common.utils.aodh-api:Get http://10.101.16.1:5000/v2/: dial tcp 10.101.16.1:5000: connect: no route to host
    INFO:kolla.common.utils.aodh-api:Pushed successfully

    This patch changes that. Now if there is an error during push then proper
    exception is raised to PushTask and image is marked with PUSH_ERROR status.

    This way at the end of build it is easy to spot which images did not got
    pushed to registry:

    INFO:kolla.common.utils:===========================
    INFO:kolla.common.utils:Images that failed to build
    INFO:kolla.common.utils:===========================
    ERROR:kolla.common.utils:base Failed with status: push_error
    ERROR:kolla.common.utils:nova-api Failed with status: push_error
    ERROR:kolla.common.utils:nova-base Failed with status: push_error
    ERROR:kolla.common.utils:nova-compute Failed with status: push_error
    ERROR:kolla.common.utils:nova-compute-ironic Failed with status: push_error
    ERROR:kolla.common.utils:nova-conductor Failed with status: push_error

    Closes-Bug: #1848019
    Change-Id: Id2ab97bf4c0dc3423268a0ea435b56f4a65f7196
    (cherry picked from commit 52cac09d3d0b8dcdbc8d68a0bcc8092008220309)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 9.0.0.0rc1

This issue was fixed in the openstack/kolla 9.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 7.1.0

This issue was fixed in the openstack/kolla 7.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 8.0.2

This issue was fixed in the openstack/kolla 8.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.