containers do not automatically restart if killed

Bug #1765802 reported by Alex Schultz on 2018-04-20
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Undecided
Unassigned
tripleo
High
Alex Schultz

Bug Description

Under docker-1.13.1-53.git774336d.el7.centos.x86_64 on centos/rhel, kolla containers do not automatically restart if killed. In researching this issue, it appears to be because with this version of docker the lack of a STOPSIGNAL in the Dockerfiles built by Kolla . By adding the STOPSIGNAL SIGTERM to the containers and rebuilding them, containers will properly restart if they are killed.

Changed in tripleo:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Alex Schultz (alex-schultz)
milestone: none → rocky-2

Reviewed: https://review.openstack.org/563322
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=039dbccb5d568953e281a21854916b60ad0a98e4
Submitter: Zuul
Branch: master

commit 039dbccb5d568953e281a21854916b60ad0a98e4
Author: Alex Schultz <email address hidden>
Date: Fri Apr 20 16:06:16 2018 -0600

    Add in a STOPSIGNAL configuration

    For docker 1.13.1, if STOPSIGNAL is not provided in the docker image,
    the container will not automatically restart the container. It might be
    better to define this in the Kolla scripts as a configuration option for
    each container, but I'm unsure if it's a problem for any other version
    so it might be best to configure this in tripleo until a newer version
    of docker is consumed. Additionally I'm not sure if any of the
    containers would need something other than STOPSIGNAL SIGTERM which
    should be the default if none is provided.

    Change-Id: I1939f9e6b2c432a672c7426ddabdcfca6ce150b7
    Related-Bug: #1765802

Reviewed: https://review.openstack.org/565527
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=8951bdee92468b503c3f0430c2c10671fed69803
Submitter: Zuul
Branch: stable/queens

commit 8951bdee92468b503c3f0430c2c10671fed69803
Author: Alex Schultz <email address hidden>
Date: Fri Apr 20 16:06:16 2018 -0600

    Add in a STOPSIGNAL configuration

    For docker 1.13.1, if STOPSIGNAL is not provided in the docker image,
    the container will not automatically restart the container. It might be
    better to define this in the Kolla scripts as a configuration option for
    each container, but I'm unsure if it's a problem for any other version
    so it might be best to configure this in tripleo until a newer version
    of docker is consumed. Additionally I'm not sure if any of the
    containers would need something other than STOPSIGNAL SIGTERM which
    should be the default if none is provided.

    Change-Id: I1939f9e6b2c432a672c7426ddabdcfca6ce150b7
    Related-Bug: #1765802
    (cherry picked from commit 039dbccb5d568953e281a21854916b60ad0a98e4)

tags: added: in-stable-queens
Changed in tripleo:
status: Triaged → Fix Released

Reviewed: https://review.openstack.org/565552
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=1db5b7421eb87d6d5c5d2490212ac1cab0bb28de
Submitter: Zuul
Branch: stable/pike

commit 1db5b7421eb87d6d5c5d2490212ac1cab0bb28de
Author: Alex Schultz <email address hidden>
Date: Fri Apr 20 16:06:16 2018 -0600

    Add in a STOPSIGNAL configuration

    For docker 1.13.1, if STOPSIGNAL is not provided in the docker image,
    the container will not automatically restart the container. It might be
    better to define this in the Kolla scripts as a configuration option for
    each container, but I'm unsure if it's a problem for any other version
    so it might be best to configure this in tripleo until a newer version
    of docker is consumed. Additionally I'm not sure if any of the
    containers would need something other than STOPSIGNAL SIGTERM which
    should be the default if none is provided.

    Change-Id: I1939f9e6b2c432a672c7426ddabdcfca6ce150b7
    Related-Bug: #1765802
    (cherry picked from commit 039dbccb5d568953e281a21854916b60ad0a98e4)

tags: added: in-stable-pike
Changed in kolla:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers