kolla

neutron-dhcp-agent dockerfile doesn't allow packages to be overridden

Bug #1753568 reported by Brent Eagles on 2018-03-05

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	kolla	Fix Released	Undecided	Brent Eagles

Bug Description

The macro.install_packages is inside the if/block for debian, making it so template overrides that set neutron_dhcp_agent_packages don't take effect.

Tags:

Brent Eagles (beagles) on 2018-03-05

Changed in kolla:
assignee:	nobody → Brent Eagles (beagles)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-03-05: Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/549851

Changed in kolla:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-03-12: Fix merged to kolla (master)

Reviewed: https://review.openstack.org/549851
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=eb3cd4f30f78b9e4c52209e9ed58f5d79fdffd3c
Submitter: Zuul
Branch: master

commit eb3cd4f30f78b9e4c52209e9ed58f5d79fdffd3c
Author: Brent Eagles <email address hidden>
Date: Mon Mar 5 15:50:11 2018 -0330

Fix neutron dhcp agent dockerfile for non-deb/ubuntu

    The macro.install_packages line was inside the if block for debian and
    ubuntu distros, making it so that setting neutron_dhcp_agent_packages
    via overrides has no effect on CentOS, etc.

Change-Id: I131ada5f92b5827fd571e698719ec12dea1e66cb
Closes-Bug: #1753568

Changed in kolla:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-03-13: Fix proposed to kolla (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/552671

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-03-14: Fix merged to kolla (stable/queens)

Reviewed: https://review.openstack.org/552671
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=9544ce947ecf10d632b1ae6da498701c6ad9fe86
Submitter: Zuul
Branch: stable/queens

commit 9544ce947ecf10d632b1ae6da498701c6ad9fe86
Author: Brent Eagles <email address hidden>
Date: Mon Mar 5 15:50:11 2018 -0330

Fix neutron dhcp agent dockerfile for non-deb/ubuntu

    The macro.install_packages line was inside the if block for debian and
    ubuntu distros, making it so that setting neutron_dhcp_agent_packages
    via overrides has no effect on CentOS, etc.

    Change-Id: I131ada5f92b5827fd571e698719ec12dea1e66cb
    Closes-Bug: #1753568
    (cherry picked from commit eb3cd4f30f78b9e4c52209e9ed58f5d79fdffd3c)