macros.install_pip() fails if working dir is different than /

Bug #1746682 reported by Martin André
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Medium
Unassigned

Bug Description

Kolla will fail to pip install when not in the root directory.

For example, this is what happens when calling the macros.install_pip() after a WORKDIR instruction that change the working directory from / to somewhere else:

INFO:kolla.common.utils.tempest-plugins:Step 4/5 : RUN if [ "$(ls /plugins)" ]; then pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /plugins/*; fi
INFO:kolla.common.utils.tempest-plugins: ---> Running in da45dc6c7699
INFO:kolla.common.utils.tempest-plugins:Could not open requirements file: [Errno 2] No such file or directory: 'requirements/upper-constraints.txt'
INFO:kolla.common.utils.tempest-plugins:

We need to pass the absolute path to requirements/upper-constraints.txt instead of a relative path.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/539859
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=0d4760eaac6ea4b0f89b36f932e7b300875e28a4
Submitter: Zuul
Branch: master

commit 0d4760eaac6ea4b0f89b36f932e7b300875e28a4
Author: Martin André <email address hidden>
Date: Thu Feb 1 09:26:44 2018 +0100

    Use absolute path in install_pip macro

    This lets us use the macro in the case there was a WORKDIR instruction
    that changed the working directory from / earlier in the dockerfile.

    Change-Id: I2369c9997ef189e7084fac7b5ace014f6f76d698
    Closes-Bug: #1746682

Changed in kolla:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 6.0.0.0rc1

This issue was fixed in the openstack/kolla 6.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.