Configuration parameter opendaylight_distro doesn't work

[jiriprox]

There is not possible to build opendaylight container with different opendaylight release than default release 0.6.0-Carbon.
Used documetation:
https://docs.openstack.org/kolla/latest/template-override/opendaylight-source.html

[Eduardo Gonzalez (egonzalez90)]

Can you please explain what fails?

[jiriprox (jirix-x-prokes)]

Hi,

Whatever I set in kola_build.conf to opendaylight_distro parameter it is not taken for build.
Dockerfile for opendaylight is using default value which is hardcoded in contrib/template-override/opendaylight-template-overrides.j2
So opendaylight_distro = distribution-karaf-0.6.0-Carbon is used all the time even if I want to use e.g. distribution-karaf-0.5.3-Boron.

I've created pull request with correction:
https://github.com/openstack/kolla/pull/31

Best Regards,

Jiri

[Eduardo Gonzalez (egonzalez90)]

I verified the issue exists. Please, for change request in openstack projects github pull requests are not used. Please, follow https://docs.openstack.org/infra/manual/developers.html

Is a bug awkward but is the only way to push changes to openstack projects. Feel free to reach me in IRC #openstack-kolla as egonzalez if need help setting out all accounts or gerrit workflow.

Regards.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/482894

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/482894
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=b76bb49dfdbe106fc5707a56573d145553f59574
Submitter: Jenkins
Branch: master

commit b76bb49dfdbe106fc5707a56573d145553f59574
Author: Eduardo Gonzalez <email address hidden>
Date: Wed Jul 12 12:27:00 2017 +0200

    Fix opendaylight custom distribution

    opendaylight_distro is not passed to Dockerfile
    while image building.
    This change removes this variable and change the
    symbolic link with the distribution passed to
    opendaylight location in kolla-build.conf

    Change-Id: I7c00a8736a7a5e7c317065438cac1b193466615c
    Closes-Bug: #1703774

[OpenStack Infra (hudson-openstack)]

Change abandoned by jiriprox (<email address hidden>) on branch: master
Review: https://review.openstack.org/482974
Reason: Review https://review.openstack.org/#/c/482894/ was merged. So abandon this one.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla 5.0.0.0b3 development milestone.