Vagrant development env broken after repo split

[Juan J. Martínez]

After kolla's repo has been split in several repos (kolla, kolla-ansible), the development environment with Vagrant in contrib/dev/vagrant seems broken as part of the bootsrap code expects kolla-ansible content to be available inside kolla's repo.

Also the content of contrib/dev/vagrant seems duplicated.

I find the vagrant environment very useful.

An easy fix could be:

- require a checkout of both repos
- provide a configuration token with the path of kolla-ansible (e.g. `kolla_ansible_path`)
- change the bootstrap code to use two different paths (kolla and kolla-ansible)
- document this and probably remove the code from kollan-ansible as building the images seems the main component (I guess support for other deployment methods could be added afterwards)
- optionally make the deployment "optional", so kolla-ansible is not required

Does this make sense? Thanks!

[chandan kumar (chkumar246)]

We also need to update the docs:
For Fedora 25:
[1.] sudo dnf install @vagrant

[2.] While setting up NFS, i hitted with mountd.service not found.
https://developer.fedoraproject.org/tools/vagrant/vagrant-nfs.html is the recommended way to setup nfs.

[3.] We donot need vagrant-vbguest for vagrant-libvirt we need to fix it.

Apart from that i hit this error on fedora 25 while doing vagrant up:
==> operator: Mounting NFS shared folders...
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

set -e
mkdir -p /home/vagrant/kolla
mount -o vers=3,udp 192.168.121.1:/opt/stack/kolla /home/vagrant/kolla
if command -v /sbin/init && /sbin/init --version | grep upstart; then
  /sbin/initctl emit --no-wait vagrant-mounted MOUNTPOINT=/home/vagrant/kolla
fi

Stdout from the command:

Stderr from the command:

mount.nfs: requested NFS version or transport protocol is not supported

[Martin André (mandre)]

If we consider kolla to be the project for container image building, probably a virtualenv is much better if you don't want to pollute your environment.

Vagrant really shines when we want to setup a development environment for the deployment tools.

So I'm thinking we should do it the other way around: have the vagrant environment in kolla-ansible (or any other deployment tool that consumes kolla images) and have it depend on kolla so we retain the ability to build images. I believe this was the original intention after the repo split - the doc was moved to kolla-ansible - but the code was duplicated, making the vagrant env effectively broken in both projects.

[Juan J. Martínez (jjmartinez)]

@mandre: sounds good to me!

I can remove it from kolla and have make kolla-ansible deal with it all requiring the kolla repo to be available.

[Juan J. Martínez (jjmartinez)]

Fix to this issue in: https://review.openstack.org/#/c/469068/

Once it is merged I'll make another PR to remove the vagrant bits from kolla repo.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/469930

[Juan J. Martínez (jjmartinez)]

PR to clean up kolla repo: https://review.openstack.org/#/c/469930/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/469930
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=4af4b1ec6f35fdc5b7687f5a7819bbab1fdb721a
Submitter: Jenkins
Branch: master

commit 4af4b1ec6f35fdc5b7687f5a7819bbab1fdb721a
Author: Juan J. Martinez <email address hidden>
Date: Thu Jun 1 16:43:31 2017 +0100

    Remove dead code related to the Vagrant dev environment

    The Vagrant dev environment is now in kolla-ansible so this code
    is not needed any more in kolla repo.

    Change-Id: I066f75057f03009810d2bb00ed09e832d328b52c
    Depends-On: I6b56822d50472f8eda6fc60f69196d3c9b8b6cf8
    Related-Bug: 1693847

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 5.0.0.0b2 development milestone.