kolla

Some images have plugins install instruction for binary install type

Bug #1681345 reported by Martin André
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
High
Martin André
Ocata
New
Undecided
Unassigned
Pike
Fix Released
High
Martin André

Bug Description

The plugin mechanism is meant to be for source install type only, however some images do not enclose the 'ADD plugins-archive /' into a conditional for source type. Even though it is not cause build failure when using the kolla-build script (due to it creating empty plugins-archive.tgz), it becomes a problem when using a different tool to build the kolla-images where docker build fails with:

"ADD plugins-archive /": "lstat plugins-archive: no such file or directory"

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/455166

Changed in kolla:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to kolla (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/455167

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/455166
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=15543949b118ec30fcc1bbfc4c2f6d9188ef7664
Submitter: Jenkins
Branch: master

commit 15543949b118ec30fcc1bbfc4c2f6d9188ef7664
Author: Martin André <email address hidden>
Date: Mon Apr 10 10:48:10 2017 +0200

    Only copy plugin-archive into image for source builds

    The plugin mechanism is meant to be for source install type only.

    Change-Id: I1371a253236b09dc62ea91dce6d652e1c5603015
    Closes-Bug: #1681345

Changed in kolla:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 5.0.0.0b2

This issue was fixed in the openstack/kolla 5.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to kolla (master)

Reviewed: https://review.openstack.org/455167
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=41dc35dc3145ad8933a9bf6a5f0580a85810a317
Submitter: Jenkins
Branch: master

commit 41dc35dc3145ad8933a9bf6a5f0580a85810a317
Author: Martin André <email address hidden>
Date: Mon Apr 10 10:52:44 2017 +0200

    Skip [plugins,additions]-archive for binary builts

    Skip the creation of `plugins-archive` or `additions-archive` for
    binary builds as they are only checked-out as part of the source build
    process. Doing so also has the nice side-effect of failing the build in
    case someone accidently includes an 'ADD plugins-archive /' instruction
    to the binary section of a Dockerfile.

    Change-Id: I7442fcd9677466dd0878e124402b4d4170a1ab68
    Related-Bug: #1681345

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.