Gate fails for stable branches

[Mohammed Naser]

The gate is currently failing for stable branches. Upon further investigating, it seems that the shell which runs the job is currently ran with sudo therefore erasing all environment variables and not letting zuul-cloner detect $ZUUL_BRANCH in order to checkout the correct version of kolla-ansible.

This meant that kolla stable/ocata would checkout kolla-ansible master instead of kolla-ansible stable/ocata. This is causing every single stable/ocata job to fail for deploys

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/446645
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=4c7a4099ca017512fdfdbd28ac47724abf900d09
Submitter: Jenkins
Branch: master

commit 4c7a4099ca017512fdfdbd28ac47724abf900d09
Author: Mohammed Naser <email address hidden>
Date: Thu Mar 16 13:28:21 2017 -0400

    Remove global privilege escalation for deploy_aio.sh

    At the moment, deploy_aio.sh is called with sudo which results
    in the environment being wiped. This means that all Zuul
    environment variables are removed and therefore when zuul-cloner
    runs to checkout the branch of kolla-ansible, it will always
    fallback to master as ZUUL_BRANCH is unset.

    This patch removes the global usage of sudo in the tox.ini file
    as there is existing usage of sudo in the bash script itself. This
    will mean that we will only escalate privileges when needed rather
    for the whole script and the environment variables should be passed
    on properly resulting in the matching release of kolla-ansible being
    checked out.

    Closes-Bug: #1673756

    Change-Id: I477a843e696be7136c020be6408afea01967879d

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/446648
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=8156551e04f1e63fd212b6fb9500d4585f999802
Submitter: Jenkins
Branch: stable/ocata

commit 8156551e04f1e63fd212b6fb9500d4585f999802
Author: Mohammed Naser <email address hidden>
Date: Thu Mar 16 13:28:21 2017 -0400

    Remove global privilege escalation for deploy_aio.sh

    At the moment, deploy_aio.sh is called with sudo which results
    in the environment being wiped. This means that all Zuul
    environment variables are removed and therefore when zuul-cloner
    runs to checkout the branch of kolla-ansible, it will always
    fallback to master as ZUUL_BRANCH is unset.

    This patch removes the global usage of sudo in the tox.ini file
    as there is existing usage of sudo in the bash script itself. This
    will mean that we will only escalate privileges when needed rather
    for the whole script and the environment variables should be passed
    on properly resulting in the matching release of kolla-ansible being
    checked out.

    Closes-Bug: #1673756

    Change-Id: I477a843e696be7136c020be6408afea01967879d
    (cherry picked from commit 4c7a4099ca017512fdfdbd28ac47724abf900d09)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla 4.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla 5.0.0.0b2 development milestone.