Able to trigger `Unknown instruction: &&`

[Joshua Harlow]

At godaddy we in our template overrides set the following.

{% set base_yum_centos_repo_keys_override = [] %}

In the kolla code this seems to trigger an issue where the following does not take that customization into account.

https://github.com/openstack/kolla/blob/master/docker/base/Dockerfile.j2#L111-L117

Basically `{%- if base_centos_yum_repo_keys|length ==0 %}RUN {% else %} && {% endif -%}` is never going through the else path, because the override is not taken into consideration here (even though its taken into consideration in the {% for key in base_centos_yum_repo_keys | customizable('yum_centos_repo_keys') %} prior to that. This causes the formed docker file to be invalid and docker to later puke.

[Joshua Harlow (harlowja)]

http://paste.openstack.org/show/599151/

[Jeffrey Zhang (jeffrey4l)]

could u push a fix?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/457121

[Martin André (mandre)]

I believe this was fixed with https://github.com/openstack/kolla/commit/d29333b7a8b24615397141958a6c7b5603d82efe

[Mike Chen (chenn2)]

I believe this issue has already been addressed by another developer here (https://review.openstack.org/#/c/454608/). So please consider closing this bug report. Regards.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Chen (<email address hidden>) on branch: master
Review: https://review.openstack.org/457121
Reason: already fixed