kolla

Wrong placement of policy.json

Bug #1639686 reported by Duong Ha-Quang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Critical
Duong Ha-Quang
kolla ocata-1 "o1"
kolla-ansible
Fix Released
Critical
Duong Ha-Quang
kolla-ansible ocata-2 "o2"

Bug Description

We add policy.json customization recently, but it's put in "{{ node_config_directory }}/{{ service_name }}" in target nodes.

The correct location is achieved by following code (nova for example):

- name: Copying over existing policy.json
  template:
    src: "{{ node_custom_config }}/{{ item }}/policy.json"
    dest: "{{ node_config_directory }}/{{ item }}/policy.json"
  when:
    nova_policy.stat.exists
  with_items:
    - "nova-api"
    - "nova-compute"
    - "nova-compute-ironic"
    - "nova-conductor"
    - "nova-consoleauth"
    - "nova-novncproxy"
    - "nova-scheduler"
    - "nova-spicehtml5proxy"

Duong Ha-Quang (duonghq)
Changed in kolla:
assignee: nobody → Duong Ha-Quang (duonghq)
Steven Dake (sdake)
Changed in kolla:
status: New → Triaged
importance: Undecided → Critical
milestone: none → ocata-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/394260

Changed in kolla:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/394260
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=c04585b7f3bb9abd5e9b0b8cd9b5657a4093ceb9
Submitter: Jenkins
Branch: master

commit c04585b7f3bb9abd5e9b0b8cd9b5657a4093ceb9
Author: Duong Ha-Quang <email address hidden>
Date: Mon Nov 7 12:00:32 2016 +0700

    Fix placement of policy.json

    Currently, policy.json is put in
    "{{ node_config_directory }}/{{ service_name }}"
    in target nodes.

    Relocation policy.json to "{{ node_config_directory }}/{{ item }}"
    with item is corresponding service compoment config directory.

    Currently, the policy.json is copied to all services, but it
    should be reviewed and left only in neccesary service
    (at many cases, only API service needs that).

    Redundant files will be removed in follow up patchset.

    Change-Id: I0e997dccf4ec438c9c0436db71ec2fd06650f50d
    Closes-Bug: #1639686

Changed in kolla:
status: In Progress → Fix Released
Eduardo Gonzalez (egonzalez90)
Changed in kolla-ansible:
status: New → Triaged
importance: Undecided → Critical
Duong Ha-Quang (duonghq)
Changed in kolla-ansible:
milestone: none → ocata-2
assignee: nobody → Duong Ha-Quang (duonghq)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.openstack.org/404092
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=b5d1e4b457e6e1f396a39f975cd79e0beca65493
Submitter: Jenkins
Branch: master

commit b5d1e4b457e6e1f396a39f975cd79e0beca65493
Author: Duong Ha-Quang <email address hidden>
Date: Mon Nov 7 12:00:32 2016 +0700

    Fix placement of policy.json

    Currently, policy.json is put in
    "{{ node_config_directory }}/{{ service_name }}"
    in target nodes.

    Relocation policy.json to "{{ node_config_directory }}/{{ item }}"
    with item is corresponding service compoment config directory.

    Currently, the policy.json is copied to all services, but it
    should be reviewed and left only in neccesary service
    (at many cases, only API service needs that).

    Redundant files will be removed in follow up patchset.

    Change-Id: I0e997dccf4ec438c9c0436db71ec2fd06650f50d
    Closes-Bug: #1639686

Changed in kolla-ansible:
status: Triaged → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 4.0.0.0b2

This issue was fixed in the openstack/kolla 4.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 4.0.0.0b2

This issue was fixed in the openstack/kolla-ansible 4.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kolla-ansible (master)

Change abandoned by Eduardo Gonzalez (<email address hidden>) on branch: master
Review: https://review.openstack.org/398563
Reason: Each change is in individual PS

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.