log directory of cinder-volume is not created

Bug #1638839 reported by Andrew Liu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Undecided
Andrew Liu
Newton
Fix Released
Undecided
Unassigned

Bug Description

If the cinder-volume is deployed in different node with other cinder containers, the /var/log/kolla/cinder directory won't be created, and it will cause the cinder-volume container can't be started.

In the Dockerfile of cinder-volume, it overwrite the "kolla_extend_start" script of cinder-base:
https://github.com/openstack/kolla/blob/master/docker/cinder/cinder-volume/Dockerfile.j2#L47

But actually, it should be name as "kolla_cinder_extend_start", like in the cinder-api:
https://github.com/openstack/kolla/blob/master/docker/cinder/cinder-api/Dockerfile.j2#L28

Revision history for this message
Andrew Liu (andrew-lhj) wrote :

I will fix this issue and commit a code review.

Changed in kolla:
assignee: nobody → Andrew Liu (andrew-lhj)
Andrew Liu (andrew-lhj)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/393201

Changed in kolla:
status: New → In Progress
Changed in kolla:
milestone: none → ocata-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/393201
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=6c2d02a614b00c8e38a0b760ceddd2f7f7cde958
Submitter: Jenkins
Branch: master

commit 6c2d02a614b00c8e38a0b760ceddd2f7f7cde958
Author: liuhongjiang <email address hidden>
Date: Thu Nov 3 17:13:01 2016 +0800

    Changed the start script name in cinder-volume

    In the Dockerfile of cinder-volume, the "kolla_extend_start" script
    will be overwritten, and it will cause the cinder-volume container
    doesn't create /var/log/kolla/cinder folder.
    The name of the start script should be "kolla_cinder_extend_start" in
    cinder-volume container.

    Change-Id: I7251792a4fbe1442e2ffc5ebd9e41bd9cdc33568
    Closes-Bug: #1638839

Changed in kolla:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/newton)

Reviewed: https://review.openstack.org/393858
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=c97404a7a34bac649178c31dded4deb1e335cb56
Submitter: Jenkins
Branch: stable/newton

commit c97404a7a34bac649178c31dded4deb1e335cb56
Author: liuhongjiang <email address hidden>
Date: Thu Nov 3 17:13:01 2016 +0800

    Changed the start script name in cinder-volume

    In the Dockerfile of cinder-volume, the "kolla_extend_start" script
    will be overwritten, and it will cause the cinder-volume container
    doesn't create /var/log/kolla/cinder folder.
    The name of the start script should be "kolla_cinder_extend_start" in
    cinder-volume container.

    Change-Id: I7251792a4fbe1442e2ffc5ebd9e41bd9cdc33568
    Closes-Bug: #1638839
    (cherry picked from commit 6c2d02a614b00c8e38a0b760ceddd2f7f7cde958)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 4.0.0.0b1

This issue was fixed in the openstack/kolla 4.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 3.0.2

This issue was fixed in the openstack/kolla 3.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.