--tag flag not working with kolla-build

[Steven Dake]

Pavo reported the following:
https://paste.fedoraproject.org/465986/86315414/

Note --tag is 3.0.1 however LABEL is 3.0.0

I have duplicated this via:

git clone http://github.com/openstack/kolla
git checkout stable/newton

[Henry Brock (pavos)]

Also effects stable/mitaka

[prameswar (prameswar)]

i am able to build images with --tag using command like :

kolla-build -b ubuntu --tag 3.0.2

or
cd kolla
./tools/build.py --tag 3.0.1 --nocache

in attached logs, there is no option "--no-cache" . you should use option "--nocache".

i have tried with mitaka , newton and master everywhere it is working. please check again and post comment if same issue exist in your system.

[Jeffrey Zhang (jeffrey4l)]

dockerfile's LABEL means kolla's version.
--tag means docker images tag number.

the label is only changed when kolla has new release version.

they are different things.

[Magnus Lööf (magnus-loof)]

I am trying to build a patched gnocchi due to https://review.openstack.org/#/c/392465/

It seems that kolla-build ignores the --tag :

$ kolla-build -n <internal name> --tag 3.0.1 gnocchi
INFO:kolla.image.build:Found the docker image folder at /usr/share/kolla/docker
INFO:kolla.image.build:Added image base to queue
INFO:kolla.image.build:Attempting to run task BuildTask(base) for the first time
INFO:kolla.image.build.base:Building
INFO:kolla.image.build.base:Step 1 : FROM centos:7
INFO:kolla.image.build.base: ---> 980e0e4c79ec
INFO:kolla.image.build.base:Step 2 : MAINTAINER Kolla Project (https://launchpad.net/kolla)
INFO:kolla.image.build.base: ---> Using cache
INFO:kolla.image.build.base: ---> c761af870b86
INFO:kolla.image.build.base:Step 3 : LABEL kolla_version "3.0.2"

I am on stable/newton :

commit 9bb45cf547a29ccb9a3cae6ced7c7abad16ff6a5
Merge: 8e91e2c a093e5f
Author: Jenkins <email address hidden>
Date: Tue Nov 1 11:41:20 2016 +0000

    Merge "Remove indentation from l3_agent.ini.j2" into stable/newton

[Magnus Lööf (magnus-loof)]

sorry, ignore previous comment. When examining docker images, there are newly built images that have docker tag 3.0.1 - so it seems it works fine when specifying the --tag for kolla-build.