Broken test to check for lsb_release availability in vagrant boostrap script

Bug #1635341 reported by Martin André
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
High
Martin André

Bug Description

Provisioning a vagrant VM from master fails with:

==> operator: /tmp/vagrant-shell: line 41: lsb_release: command not found
==> operator: /tmp/vagrant-shell: line 41: lsb_release: command not found
==> operator: Unsupported Distro:
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

The check for availability of lsb_release was broken with https://github.com/openstack/kolla/commit/1b8c4ff7798273cc0f2cc79465773f271e66f3d2

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/389266

Changed in kolla:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/389266
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=193a8190ce16d6b356957d77c81c78eaed20d962
Submitter: Jenkins
Branch: master

commit 193a8190ce16d6b356957d77c81c78eaed20d962
Author: Martin André <email address hidden>
Date: Thu Oct 20 18:11:26 2016 +0200

    Fix broken test in vagrant boostrap script

    The file path was not properly passed to the '-x' test which caused it
    to always return true.

    This commit simplifies the test for existing command by relying only on
    the exit code of `type` rather than checking that the file path is
    executable.

    Change-Id: Iaf47d92ff9fd1ef34d8d7492c08ec24d2b8a9536
    Closes-Bug: #1635341

Changed in kolla:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 4.0.0.0b1

This issue was fixed in the openstack/kolla 4.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.