kolla

JSON validation script is broken

Bug #1634447 reported by Christian Berendt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
High
Jeffrey Zhang
kolla ocata-1 "o1"

Bug Description

tools/validate-all-json.sh is broken, we only check for *.json files. But we only use *.json.j2 files. Templates files have to be rendered and checked for valid syntax afterwards.

See original description
Christian Berendt (berendt)
description: updated
Changed in kolla:
assignee: nobody → Jeffrey Zhang (jeffrey4l)
status: New → Confirmed
importance: Undecided → High
milestone: none → ocata-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/388851

Changed in kolla:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/388851
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=2392d7e38cc5937921c2ecaf5af2b21f3cb32c40
Submitter: Jenkins
Branch: master

commit 2392d7e38cc5937921c2ecaf5af2b21f3cb32c40
Author: Jeffrey Zhang <email address hidden>
Date: Thu Oct 20 02:21:35 2016 +0800

    Add file validator for *.json.j2 file

    All json file in Kolla are json.j2 file, it shold be render as jinja
    template, then validate by using json.

    Change-Id: Ibabbe435116fd255d68347e00407156db76fedfe
    Closes-Bug: #1634447

Changed in kolla:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/394206

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 4.0.0.0b1

This issue was fixed in the openstack/kolla 4.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kolla (stable/newton)

Change abandoned by Steven Dake (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/394206

Jeffrey Zhang (jeffrey4l)
no longer affects: kolla/newton
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.