kolla build and dockerfile filenames do not match for sources.list

Bug #1633187 reported by sean mooney on 2016-10-13
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
kolla
Undecided
Unassigned

Bug Description

supplying custom apt_sources_list and apt_preferences is supported via the kolla-build.conf when building
docker images.

currently the filenames used by the build.py script
https://github.com/openstack/kolla/blob/master/kolla/image/build.py#L615
and docker file
https://github.com/openstack/kolla/blob/master/docker/base/Dockerfile.j2#L217
do not match.

to support custom sources.list and preferences the build.py needs to be updated to include the base distro in the filename.

https://github.com/openstack/kolla/blob/master/docker/base/Dockerfile.j2#L217

Jeffrey Zhang (jeffrey4l) wrote :

shouldn't we move to dockerfile customization?

Changed in kolla:
status: New → Confirmed
milestone: none → ocata-1
Praveen N (praveenn) on 2016-10-14
Changed in kolla:
assignee: nobody → Praveen N (praveenn)
sean mooney (sean-k-mooney) wrote :

hi praveen i was already working on this and had a patch up.
i have split out this section and resubmit here.

https://review.openstack.org/#/c/386592/

Changed in kolla:
assignee: Praveen N (praveenn) → sean mooney (sean-k-mooney)
sean mooney (sean-k-mooney) wrote :

Jeffery there is not entrypoint that is convianent for updating this via the docker customization.
talking to michal(inc0) on irc he was suggesting that we could move it to a template in the future too.

currently this is broken on the newton branch so this bug is opened so we can backport the fix to newton without effect the current behavior. in ocata we can convert to either a template or docker customization.
to do that i belive we would need to follow the config deprecation workflow so we should deprecate it in newton if we want to remove it in ocata.

Praveen N (praveenn) wrote :

@ Sean, That's alright !!

Changed in kolla:
milestone: ocata-1 → ocata-2
Changed in kolla:
milestone: ocata-2 → ocata-3
Changed in kolla:
importance: Undecided → Low
Edmund Rhudy (erhudy) wrote :

I fixed this as part of https://review.openstack.org/#/c/414639, but the PR breaks at the Ubuntu gates because they supply a custom sources.list and that custom sources.list is actually getting used now. It seems that the Ubuntu gates only actually worked because of the presence of this particular bug.

Change abandoned by Edmund Rhudy (<email address hidden>) on branch: master
Review: https://review.openstack.org/414639
Reason: abandoning this change in favor of the approach in https://review.openstack.org/#/c/419610/

Change abandoned by sean mooney (<email address hidden>) on branch: master
Review: https://review.openstack.org/386592

This is an automated cleanup. This bug report has been closed because it
is older than 18 months and there is no open code change to fix this.
After this time it is unlikely that the circumstances which lead to
the observed issue can be reproduced.

If you can reproduce the bug, please:
* reopen the bug report (set to status "New")
* AND add the detailed steps to reproduce the issue (if applicable)
* AND leave a comment "CONFIRMED FOR: <RELEASE_NAME>"
  Only still supported release names are valid (OCATA, PIKE, QUEENS, ROCKY, ROCKY).
  Valid example: CONFIRMED FOR: OCATA

Changed in kolla:
assignee: sean mooney (sean-k-mooney) → nobody
importance: Low → Undecided
status: Confirmed → Expired
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers