Destroy needs to have the option to be slightly less destructive

[Borne Mace]

I have the need to do cleanup but want to be able to preserve some data, such as the information in etc, and the container data volumes. To make sure the data is in a non-corrupt state allowing the kill timeout to be a bit larger would be necessary as well.

[Jeffrey Zhang (jeffrey4l)]

in most of case, volumes is stateful. it will be wrong to preserve data in data volumes. for example the rabbitmq and mysql.

[Borne Mace (borne-mace)]

agreed that in most cases that is true jeffry, which is why this is only a non-default option. i think it is still useful in AIO (all in one) scenarios where deleting the data means its only instance is gone.

[Jeffrey Zhang (jeffrey4l)]

i do not think that's easy to implement just remove or keep some named volume.

remove the instance mean to remove some items in the mariadb db.

you may need some script to clean up the nova/neutorn/cinder service, i think. rather than keep some named volume.

[Borne Mace (borne-mace)]

i'm not sure you understood what I said. I agree that in most scenarios people probably don't want to preserve the data, which is why this is just a non-default option. In all in one environments where there is only one control node this new option allows someone to just bring down their containers without deleting all the associated data rather than wiping out everything.

[Jeffrey Zhang (jeffrey4l)]

if you just want to use a newer container, upgrade action will work. I still do not think we need you feature, even in AIO environment.
if you want to use an older container, all the data volume should be removed in case of compatible issue.

[OpenStack Infra (hudson-openstack)]

Change abandoned by BorneMace (<email address hidden>) on branch: master
Review: https://review.openstack.org/377837
Reason: going to abort this for now and possibly introduce a separate stop option that is non-destructive.

[Borne Mace (borne-mace)]

Associated change has been abandoned. Feel free to nuke this bug or whatever the appropriate disposition would be: https://review.openstack.org/#/c/377837/

[Steven Dake (sdake)]

bmace requested this be set to invalid on irc.