neutron_dvr fails to deploy

[bjolo]

deployement failes due to undefind external_network_bridge. The code does not provide a default value, and the documentation does not specify that or what that should be.

code
/kolla/ansible/roles/neutron/templates/l3_agent.ini.j2
external_network_bridge =

It is only mentioned at one place in the codebase. Is it used or should it be removed?
http://opengrok.cloudonly.se/source/search?q=external_network_bridge&defs=&refs=&path=&hist=&type=&project=kolla

log file
http://paste.openstack.org/show/582733/

[Paul Bourke (pauldbourke)]

I believe an empty value is correct for the default case (https://github.com/openstack/neutron/blob/master/neutron/conf/agent/l3/config.py#L56-L62)

This is a templating problem in ansible, I think I've seen it before but trying to remember when. Can you please post the output with -vvv

[bjolo (bjorn-lofdahl)]

deploy -vvv log
http://paste.openstack.org/show/584192/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/381919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/381919
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=cc0709792ba0d9fa03e53307f3fa833d4e44552b
Submitter: Jenkins
Branch: master

commit cc0709792ba0d9fa03e53307f3fa833d4e44552b
Author: Paul Bourke <email address hidden>
Date: Tue Oct 4 16:19:26 2016 +0100

    Fix l3_agent.ini rendering error when DVR

    The if/else blocks in this file cause a rendering error on control nodes
    when enable_neutron_dvr: yes

    ParsingError: File contains parsing errors: <???>
            [line 3]: u' external_network_bridge =\n'

    Change-Id: Ia461dcbbec531c4c6295b3c7e10da12c57b7d58b
    Closes-Bug: 1626995

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla 3.0.0.0rc2 release candidate.