Tech-debt: don't use signal handlers to handle ctrl-c
Bug #1586476 reported by
Joshua Harlow
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
kolla |
Fix Released
|
Medium
|
Joshua Harlow |
Bug Description
When running in a multi-threaded program (which the kolla build command is) it is bad practice to try to forcefully (and typically incorrectly) shutdown by doing things like 'sys.exit' to exit the main program when those threads are active. Instead the ctrl-c interrupt should be handled gracefully and the threads should be requested to stop, and then they should be waited until they are stopped and then (and only then) should the main program actually stop.
This isn't rocket science, and is well documented all over the web (such as in http://
Changed in kolla: | |
assignee: | nobody → Joshua Harlow (harlowja) |
Changed in kolla: | |
status: | New → In Progress |
Changed in kolla: | |
importance: | Undecided → Medium |
milestone: | none → newton-1 |
To post a comment you must log in.
I figured since most of the processing work was being given to docker, it didn't matter if the threads were terminated violently. Do you disagree with that?