kolla

clean up not run when sigint occurs during build

Bug #1579242 reported by Jeff Peeler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
High
Jeff Peeler
kolla newton-1 "n1"
Liberty
Won't Fix
High
Jeff Peeler
kolla 1.1.3 "liberty"
Mitaka
Won't Fix
High
Jeff Peeler
kolla 2.0.4 "mitaka"

Bug Description

A while ago a todo was put in build.py to implement a proper sigint handler. The reason being is when the build is interrupted the dockerfiles in /tmp remain.

Jeff Peeler (jpeeler-z)
Changed in kolla:
assignee: nobody → Jeff Peeler (jpeeler-z)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/313706

Changed in kolla:
status: New → In Progress
Swapnil Kulkarni (coolsvap-deactivatedaccount)
Changed in kolla:
importance: Undecided → High
milestone: none → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/313706
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=75492cf82b4692eca5939f22c8db1fb89d278df7
Submitter: Jenkins
Branch: master

commit 75492cf82b4692eca5939f22c8db1fb89d278df7
Author: Jeff Peeler <email address hidden>
Date: Fri May 6 17:37:42 2016 -0400

    Implement non-default signal handler for SIGINT

    Pressing Ctrl-C will stop a build, but does not clean up the /tmp
    directory of dockerfiles. Implement a signal handler such that clean up
    does occur.

    Python apparently ignores signals while calling join on a queue, so
    that's why the small modification was needed there.

    Change-Id: I43faf67726c154b6640d3596aea61ffc59871999
    Closes-Bug: #1579242

Changed in kolla:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/kolla 3.0.0.0b1

This issue was fixed in the openstack/kolla 3.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.