kolla-build return wrong exit code

[Stephane Boisvert]

running kolla-build in jenkins. I figured out that the return code is always 1 even if the build is done without any error

See the logs here

http://paste.openstack.org/show/496163/

[Hui Kang (huikang27)]

what is the command you use to build kolla image? Thanks. - Hui

[Stephane Boisvert (stephane-boisvert)]

kolla-build --push --nocache --type source --base ubuntu --registry myregistry.example.com:5000 --namespace dev -T 10 --include-header docker.file

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/322115
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=18ae114e7557ecc0a5692ea3a22b418df7bba52f
Submitter: Jenkins
Branch: master

commit 18ae114e7557ecc0a5692ea3a22b418df7bba52f
Author: Will Miller <email address hidden>
Date: Wed May 25 04:04:52 2016 -0500

    Fix kolla-build return codes

    Add a main wrapper function to return 1 if any images failed to build;
    otherwise, return 0. Rename the old main() to run_build(), which still
    returns image statuses, to avoid interfering with unit tests.

    Change-Id: I5817cc9cebb4f42dc13e0535223e5dc8931a3aab
    Co-Authored-By: Mark Goddard <email address hidden>
    Closes-Bug: #1578404

[Christian Berendt (berendt)]

After the merge of this change I got the following error when running with the parameter --template-only:

kolla-build --config-file kolla-build.conf --template-only neutron
INFO:kolla.cmd.build:Found the docker image folder at /usr/local/share/kolla/docker
INFO:kolla.cmd.build:Dockerfiles are generated in /tmp/kolla-2016-05-31_16-31-59_ctuce_/docker
Traceback (most recent call last):
  File "/usr/local/bin/kolla-build", line 10, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/kolla/cmd/build.py", line 795, in main
    bad_results, good_results, unmatched_results = run_build()
TypeError: 'NoneType' object is not iterable

[Christian Berendt (berendt)]

Reported in a separate bug report: https://bugs.launchpad.net/kolla/+bug/1587501

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/kolla 3.0.0.0b1 development milestone.