zookeeper dependencies no longer needed in bootstrapping codebase

Bug #1577194 reported by Steven Dake
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
High
Steven Dake
Liberty
Fix Released
High
Steven Dake
Mitaka
Fix Released
High
Steven Dake

Bug Description

SInce kolla-mesos was retired, zookeeper access libraries are no longer needed. I suspect kubernetes with config maps or the like will handle this problem differently so removing entirely from the code base. It will remain in the git history so folks can see how it worked int he past if we chose to use etcd with kubernetes work.

Revision history for this message
Steven Dake (sdake) wrote :

To have kept this work around and had proper functionality of build from source, it would have been necessary to create a virtualenv for the python packages in the base image. Since we are no longer doing this, fixing this bug kills two birds with one stone.

Changed in kolla:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Steven Dake (sdake)
milestone: none → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/311632

Changed in kolla:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/311632
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=025d57f82005a4ea92950f9b4d717c88f647d15f
Submitter: Jenkins
Branch: master

commit 025d57f82005a4ea92950f9b4d717c88f647d15f
Author: Steven Dake <email address hidden>
Date: Sun May 1 14:00:54 2016 -0400

    Remove dependencies on kazoo and friends

    Since kolla-mesos has been retired, there is no need in the code
    base to keep the zookeeper implementation. As a result, just remove
    it. If we were to keep it we need virtualenvs for that part of the
    code base which installs the python dependencies related to it
    for from-binary installs.

    This just simplifies the implementation tremendously and culls dead
    code.

    Change-Id: Ieda226e652d67f5b5667112f4f2556f3171366d3
    Closes-Bug: #1577194

Changed in kolla:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/312776

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/312777

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/mitaka)

Reviewed: https://review.openstack.org/312777
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=ece6638d268e81bdf119d29ca30b7d464876aacc
Submitter: Jenkins
Branch: stable/mitaka

commit ece6638d268e81bdf119d29ca30b7d464876aacc
Author: Steven Dake <email address hidden>
Date: Sun May 1 14:00:54 2016 -0400

    Remove dependencies on kazoo and friends

    Since kolla-mesos has been retired, there is no need in the code
    base to keep the zookeeper implementation. As a result, just remove
    it. If we were to keep it we need virtualenvs for that part of the
    code base which installs the python dependencies related to it
    for from-binary installs.

    This just simplifies the implementation tremendously and culls dead
    code.

    Closes-Bug: #1577194
    (cherry picked from commit 025d57f82005a4ea92950f9b4d717c88f647d15f)

    Conflicts:
     docker/base/Dockerfile.j2
     docker/kolla-toolbox/Dockerfile.j2

    Change-Id: Ieda226e652d67f5b5667112f4f2556f3171366d3

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/liberty)

Reviewed: https://review.openstack.org/312776
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=362fd8c67d59322d1aa487bddc30ea9019c9ba18
Submitter: Jenkins
Branch: stable/liberty

commit 362fd8c67d59322d1aa487bddc30ea9019c9ba18
Author: Steven Dake <email address hidden>
Date: Sun May 1 14:00:54 2016 -0400

    Remove dependencies on kazoo and friends

    Since kolla-mesos has been retired, there is no need in the code
    base to keep the zookeeper implementation. As a result, just remove
    it. If we were to keep it we need virtualenvs for that part of the
    code base which installs the python dependencies related to it
    for from-binary installs.

    This just simplifies the implementation tremendously and culls dead
    code.

    Closes-Bug: #1577194
    (cherry picked from commit 025d57f82005a4ea92950f9b4d717c88f647d15f)

    Conflicts:
     docker/base/Dockerfile.j2
     docker/kolla-toolbox/Dockerfile.j2

    Change-Id: Ieda226e652d67f5b5667112f4f2556f3171366d3

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/kolla 1.1.0

This issue was fixed in the openstack/kolla 1.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/kolla 3.0.0.0b1

This issue was fixed in the openstack/kolla 3.0.0.0b1 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/kolla 2.0.1

This issue was fixed in the openstack/kolla 2.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to kolla (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/357866

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to kolla (master)

Reviewed: https://review.openstack.org/357866
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=e0a9347ebc3e7a0ad2d267f63a2d8691a65985d0
Submitter: Jenkins
Branch: master

commit e0a9347ebc3e7a0ad2d267f63a2d8691a65985d0
Author: Szymon Konefal <email address hidden>
Date: Fri Aug 19 15:13:31 2016 +0200

    Remove Kazoo dependency and Kolla Zookeeper helper

    Related-Bug: #1577194

    Change-Id: Idad2a78d3b4251a321c1a05b435bff4625d5fe56

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.