recent change to qemu.conf breaks some deployments

[Mark Casey]

The Dockerfile template for the nova_libvirt container has a sed one-liner intended to set the parameter "stdio_handler" to equal "file" (https://github.com/openstack/kolla/blob/stable/mitaka/docker/nova/nova-libvirt/Dockerfile.j2#L32).

This is done so that libvirt operates like it is less than version 1.3.0 and does not look for a new daemon that was introduced in 1.3.0. This is what happens when 1.3.0 is installed without this option: https://bugzilla.redhat.com/show_bug.cgi?id=1290357

The option was added to Kolla here: https://review.openstack.org/#/c/279910/

However from what I'm seeing this is not being set because the template for /etc/libvirt/qemu.conf is currently empty, which for me at least is causing the "libvirtError: Failed to connect socket to '/var/run/libvirt/virtlogd-sock': No such file or directory
" error mentioned in the redhat bug linked above.

Assuming this assessment is correct the nova_libvirt Dockerfile template should be changed to set "stdio_handler" as desired if the option is present BUT also add the desired line if there is not existing value.

some info on the environment in which I'm seeing this:
branch in use: stable/mitaka
distro: Ubuntu 15.10
install type: source
multinode
KVM enabled / non qemu

[Mark Casey (mark-casey)]

I forgot to mention that if I use ansible to add this option on my target nodes and restart nova_libvirt container I am then able to start VMs without error.

ansible -i /usr/local/share/kolla/ansible/inventory/multinode -m shell -a 'echo "stdio_handler = \"file\"" >> /etc/kolla/nova-libvirt/qemu.conf' all

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/308780

[OpenStack Infra (hudson-openstack)]

Change abandoned by Steven Dake (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/308780
Reason: error in workflow

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/308749
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=a861450fd29d7a2ea56eb755473da171443b38f6
Submitter: Jenkins
Branch: master

commit a861450fd29d7a2ea56eb755473da171443b38f6
Author: Steven Dake <email address hidden>
Date: Thu Apr 21 01:08:04 2016 -0400

    Fix failure to deploy with qemu.conf

    Closes-Bug: #1572819

    Change-Id: I1f2edb482af1e85708159a0dba44a79427dc5af3

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michal Rostecki (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/308780

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/308780
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=81f016bd3b9023faeadd25409a5a5005dba80f01
Submitter: Jenkins
Branch: stable/mitaka

commit 81f016bd3b9023faeadd25409a5a5005dba80f01
Author: Steven Dake <email address hidden>
Date: Thu Apr 21 01:08:04 2016 -0400

    Fix failure to deploy with qemu.conf

    Closes-Bug: #1572819

    Change-Id: I1f2edb482af1e85708159a0dba44a79427dc5af3
    (cherry picked from commit a861450fd29d7a2ea56eb755473da171443b38f6)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/308820
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=abf22e991c6d9ac14bbc4714b3bacd9238213761
Submitter: Jenkins
Branch: stable/liberty

commit abf22e991c6d9ac14bbc4714b3bacd9238213761
Author: Steven Dake <email address hidden>
Date: Thu Apr 21 01:08:04 2016 -0400

    Fix failure to deploy with qemu.conf

    Closes-Bug: #1572819

    Change-Id: I1f2edb482af1e85708159a0dba44a79427dc5af3
    (cherry picked from commit a861450fd29d7a2ea56eb755473da171443b38f6)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/kolla 2.0.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/kolla 1.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/kolla 3.0.0.0b1 development milestone.