failed to upgrade in stable/mitaka

[Kuo-tung Kao (jelly)]

How to reproduce

-----
In the first, btrfs as storage backend is needed.

$ build.py --push --registry server:4000
$ build.py --tag 2.0.1 --push --registry server:4000
$ kolla-ansible deploy
change version in globals.yml to 2.0.1
upgrade kolla
-----

As the result, some images will not be changed.
Like
http://paste.fedoraproject.org/354874/46052979/

[Steven Dake (sdake)]

after an upgrade, ovs blows up when launching new vms as well:
http://paste.fedoraproject.org/354879/53126814

[Jeffrey Zhang (jeffrey4l)]

 the root cause is: the image id of 2.0.0 and 2.0.1 is the same. So it won't re-create the container with the latest image tag.

need some change in the kolla_docker.py file and handle this case.

[Kuo-tung Kao (jelly) (coding1314)]

The bug will not happen when old docker since old docker use uuid as image id.
But in new docker, 1.10, it generate image id based on docker image content hash.
It will do nothing when image id is the same in current kolla_docker.py.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/305078

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/305078
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=9575417b15a7d7568e0c090838b10a7280287bec
Submitter: Jenkins
Branch: master

commit 9575417b15a7d7568e0c090838b10a7280287bec
Author: Jeffrey Zhang <[e-mail]>
Date: Wed Apr 13 17:56:29 2016 +0800

    Fix the upgrade issue when image id is the same

    When image id is the same, the container won't re-create with the
    latest image tag.

    Change-Id: I402ad275c388006248cb559851b01b0b963cf170
    Closes-Bug: #1569723

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/305133
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=5de4f3a21b7a918c91ce4c68b316bda56b5f2665
Submitter: Jenkins
Branch: stable/mitaka

commit 5de4f3a21b7a918c91ce4c68b316bda56b5f2665
Author: Jeffrey Zhang <[e-mail]>
Date: Wed Apr 13 17:56:29 2016 +0800

    Fix the upgrade issue when image id is the same

    When image id is the same, the container won't re-create with the
    latest image tag.

    Change-Id: I402ad275c388006248cb559851b01b0b963cf170
    Closes-Bug: #1569723
    (cherry picked from commit 9575417b15a7d7568e0c090838b10a7280287bec)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/kolla 2.0.0.0rc4 release candidate.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/kolla 2.0.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/kolla 1.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/kolla 3.0.0.0b1 development milestone.