Move out mariadb BOOTSTRAP_ARGS to start.sh

Bug #1559487 reported by Ryan Hallisey on 2016-03-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Wishlist
Ryan Hallisey

Bug Description

https://review.openstack.org/#/c/294921/

Mariadb is setting BOOTSTRAP_ARGS that are only used in a mariadb bootstrap. BOOTSTRAP_ARGS overwrite ARGS in start.sh so that we can bootstrap on the first time mariadb is started and on a recovery. This is a unique case because we are running a bootstrap in two different scenarios.

Ryan Hallisey (rthall14) on 2016-03-19
Changed in kolla:
importance: Undecided → Wishlist
milestone: none → newton-1
assignee: nobody → Ryan Hallisey (rthall14)
assignee: Ryan Hallisey (rthall14) → nobody
assignee: nobody → Ryan Hallisey (rthall14)
Sam Yaple (s8m) wrote :

I am not sure I agree with moving the BOOTSTRAP_ARGS into start.sh, since that _is_ what ARGS is for. What good would it be to do that?

Perhaps we just unblock ARGS but this feels like i may be code churn type work. let me know what you think

Ryan Hallisey (rthall14) wrote :

ARGS was made with this capability, but this unique case brought to mind that we don't really append to ARGS we just overwrite. That's fine, I can live with that. I was more considering the possibility that this could be useful in other scenarios that we haven't hit yet. My comments are meant to be provocative. I think we can just have this around as a wish-list item and if BOOTSTRAP_ARGS or ADDITIONAL_ARGS is needed for another special case in the future, we consider building it into start.sh.

Changed in kolla:
milestone: newton-1 → none
summary: - Tech-debt: Move out mariadb BOOTSTRAP_ARGS to start.sh
+ Move out mariadb BOOTSTRAP_ARGS to start.sh
Steven Dake (sdake) wrote :

I'd rather not add speculative features without a real-world use case. If you can provide one (like someone needs to append boot args) we can likely come up with a tidy solution.

Changed in kolla:
status: New → Triaged
Changed in kolla:
milestone: none → ocata-3
Christian Berendt (berendt) wrote :

Any known use cases?

Changed in kolla:
status: Triaged → Incomplete
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers