compare_environment compares incorrect

[Andrey Shestakov]

ceph_mon bootstrap container don't restarts as expected.

The first task
https://github.com/openstack/kolla/blob/master/ansible/roles/ceph/tasks/generate_cluster.yml#L7
runs container with KOLLA_BOOTSTRAP env variable, and this container should be restarted by this task
https://github.com/openstack/kolla/blob/master/ansible/roles/ceph/tasks/start_mons.yml

But second tasks has no environment variables, and compare_environment make decision that environment is not different.
This cause hang in ceph_mon container on bootstrap stage.

[Steven Dake (sdake)]

Derek,

You took this bug on 3/7 but there has been no progress for nearly 3 weeks. Still planning to solve it?

Thanks
-steve

[Derek Yang (hswayne77)]

Sorry, Steve. I'm a little busy recently, so I have no any time to solve
this bug.
Therefore, I quit this bug assignee to you.

2016-03-26 22:50 GMT+08:00 Steven Dake <email address hidden>:

> ** Changed in: kolla/mitaka
> Milestone: mitaka-rc2 => mitaka-rc3
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1534547
>
> Title:
> compare_environment compares incorrect
>
> Status in kolla:
> Triaged
> Status in kolla mitaka series:
> Triaged
>
> Bug description:
> ceph_mon bootstrap container don't restarts as expected.
>
> The first task
>
> https://github.com/openstack/kolla/blob/master/ansible/roles/ceph/tasks/generate_cluster.yml#L7
> runs container with KOLLA_BOOTSTRAP env variable, and this container
> should be restarted by this task
>
> https://github.com/openstack/kolla/blob/master/ansible/roles/ceph/tasks/start_mons.yml
>
> But second tasks has no environment variables, and compare_environment
> make decision that environment is not different.
> This cause hang in ceph_mon container on bootstrap stage.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kolla/+bug/1534547/+subscriptions
>

[Steven Dake (sdake)]

Derek,

Thanks for getting back to me. I'm sure someone else in the community will pick it up.

Regards
-steve

[Steven Dake (sdake)]

Mlima said this is fixed by https://review.openstack.org/#/c/283887/

However, I would expect to see changes in kolla_docker:compare_environment which are not present in the above patch. Note the above patch is also already in stable/mitaka.

If I could get third party confirmation this is already fixied in all our branches I'll mark it as such.

[Steven Dake (sdake)]

Addressed here:
https://review.openstack.org/#/c/283887/4/ansible/roles/ceph/tasks/start_mons.yml