mariadb task incorrectly reports state change

Bug #1491751 reported by Vladislav Belogrudov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
High
Vladislav Belogrudov

Bug Description

TASK: [mariadb | Creating haproxy mysql user] ********************************* fatal: [localhost] => Failed to template {{ (haproxy_user.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}: an unexpected type error occurred. Error was expected string or buffer

We are missing check here. It should look like

changed_when: "{{ haproxy_user.stdout.find('localhost | SUCCESS => ') != -1 and (haproxy_user.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}"

Changed in kolla:
importance: Undecided → Critical
importance: Critical → High
assignee: nobody → Vladislav Belogrudov (vlad-belogrudov)
milestone: none → liberty-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/220066

Changed in kolla:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/220066
Committed: https://git.openstack.org/cgit/stackforge/kolla/commit/?id=64180f67355e4f1afe8f494d6e8c7a08f3fa10d6
Submitter: Jenkins
Branch: master

commit 64180f67355e4f1afe8f494d6e8c7a08f3fa10d6
Author: Vladislav Belogrudov <email address hidden>
Date: Thu Sep 3 13:02:44 2015 +0300

    Ansible register task for MariaDB incorrectly reports failure

    When running register task for MariaDB we should firstly check
    if operation failed before trying to parse result from json output

    Change-Id: Ic331ec20990277d30b147826ff24affb27d52383
    Closes-Bug: #1491751

Changed in kolla:
status: In Progress → Fix Committed
Sam Yaple (s8m)
Changed in kolla:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.