Activity log for bug #1485710

Date Who What changed Old value New value Message
2015-08-17 18:02:23 XiaBing Yao bug added bug
2015-08-17 18:03:05 XiaBing Yao description The config-external.sh content in rabbitmq and glance is the different style,like follow: kolla/docker_templates/rabbitmq/config-external.sh: # Cluster configuration # Cluster configuration if [[ -f /opt/kolla/rabbitmq/rabbitmq.config ]]; then cp -af /opt/kolla/rabbitmq/rabbitmq.config /etc/rabbitmq/rabbitmq.config chown rabbitmq: /etc/rabbitmq/rabbitmq.config chmod 0600 /etc/rabbitmq/rabbitmq.config if [[ -f /opt/kolla/rabbitmq/rabbitmq-env.conf ]]; then if [[ -f "$SOURCE_ENV" ]]; then cp -af /opt/kolla/rabbitmq/rabbitmq-env.conf /etc/rabbitmq/rabbitmq-env.conf chown rabbitmq: /etc/rabbitmq/rabbitmq-env.conf chmod 0600 /etc/rabbitmq/rabbitmq-env.conf fi kolla/docker_templates/glance/glance-api/config-external.sh: #!/bin/bash SOURCE="/opt/kolla/glance-api/glance-api.conf" TARGET="/etc/glance/glance-api.conf" OWNER="glance" if [[ -f "$SOURCE" ]]; then cp $SOURCE $TARGET chown ${OWNER}: $TARGET chmod 0644 $TARGET fi I think it's better to use variables SOURCE and TARGET in config-external.sh to keep consistant with glance, so it will easy to modify it in future, and galera,keystone,swift have the same issue. The config-external.sh content in rabbitmq and glance is the different style,like follow: kolla/docker_templates/rabbitmq/config-external.sh: # Cluster configuration # Cluster configuration  if [[ -f /opt/kolla/rabbitmq/rabbitmq.config ]]; then      cp -af /opt/kolla/rabbitmq/rabbitmq.config /etc/rabbitmq/rabbitmq.config      chown rabbitmq: /etc/rabbitmq/rabbitmq.config      chmod 0600 /etc/rabbitmq/rabbitmq.config if [[ -f /opt/kolla/rabbitmq/rabbitmq-env.conf ]]; then if [[ -f "$SOURCE_ENV" ]]; then      cp -af /opt/kolla/rabbitmq/rabbitmq-env.conf /etc/rabbitmq/rabbitmq-env.conf      chown rabbitmq: /etc/rabbitmq/rabbitmq-env.conf      chmod 0600 /etc/rabbitmq/rabbitmq-env.conf fi kolla/docker_templates/glance/glance-api/config-external.sh: #!/bin/bash SOURCE="/opt/kolla/glance-api/glance-api.conf" TARGET="/etc/glance/glance-api.conf" OWNER="glance" if [[ -f "$SOURCE" ]]; then     cp $SOURCE $TARGET     chown ${OWNER}: $TARGET     chmod 0644 $TARGET fi I think it's better to use variables SOURCE and TARGET in config-external.sh to keep consistant with glance, so it will easy to modify it in future, and galera,keystone,swift have the same issue.
2015-08-17 18:04:19 XiaBing Yao description The config-external.sh content in rabbitmq and glance is the different style,like follow: kolla/docker_templates/rabbitmq/config-external.sh: # Cluster configuration # Cluster configuration  if [[ -f /opt/kolla/rabbitmq/rabbitmq.config ]]; then      cp -af /opt/kolla/rabbitmq/rabbitmq.config /etc/rabbitmq/rabbitmq.config      chown rabbitmq: /etc/rabbitmq/rabbitmq.config      chmod 0600 /etc/rabbitmq/rabbitmq.config if [[ -f /opt/kolla/rabbitmq/rabbitmq-env.conf ]]; then if [[ -f "$SOURCE_ENV" ]]; then      cp -af /opt/kolla/rabbitmq/rabbitmq-env.conf /etc/rabbitmq/rabbitmq-env.conf      chown rabbitmq: /etc/rabbitmq/rabbitmq-env.conf      chmod 0600 /etc/rabbitmq/rabbitmq-env.conf fi kolla/docker_templates/glance/glance-api/config-external.sh: #!/bin/bash SOURCE="/opt/kolla/glance-api/glance-api.conf" TARGET="/etc/glance/glance-api.conf" OWNER="glance" if [[ -f "$SOURCE" ]]; then     cp $SOURCE $TARGET     chown ${OWNER}: $TARGET     chmod 0644 $TARGET fi I think it's better to use variables SOURCE and TARGET in config-external.sh to keep consistant with glance, so it will easy to modify it in future, and galera,keystone,swift have the same issue. The config-external.sh content in rabbitmq and glance is the different style,like follow: kolla/docker_templates/rabbitmq/config-external.sh: # Cluster configuration # Cluster configuration  if [[ -f /opt/kolla/rabbitmq/rabbitmq.config ]]; then      cp -af /opt/kolla/rabbitmq/rabbitmq.config /etc/rabbitmq/rabbitmq.config      chown rabbitmq: /etc/rabbitmq/rabbitmq.config      chmod 0600 /etc/rabbitmq/rabbitmq.config if [[ -f /opt/kolla/rabbitmq/rabbitmq-env.conf ]]; then      cp -af /opt/kolla/rabbitmq/rabbitmq-env.conf /etc/rabbitmq/rabbitmq-env.conf      chown rabbitmq: /etc/rabbitmq/rabbitmq-env.conf      chmod 0600 /etc/rabbitmq/rabbitmq-env.conf fi kolla/docker_templates/glance/glance-api/config-external.sh: #!/bin/bash SOURCE="/opt/kolla/glance-api/glance-api.conf" TARGET="/etc/glance/glance-api.conf" OWNER="glance" if [[ -f "$SOURCE" ]]; then     cp $SOURCE $TARGET     chown ${OWNER}: $TARGET     chmod 0644 $TARGET fi I think it's better to use variables SOURCE and TARGET in config-external.sh to keep consistant with glance, so it will easy to modify it in future, and galera,keystone,swift have the same issue.
2015-08-17 18:04:44 XiaBing Yao description The config-external.sh content in rabbitmq and glance is the different style,like follow: kolla/docker_templates/rabbitmq/config-external.sh: # Cluster configuration # Cluster configuration  if [[ -f /opt/kolla/rabbitmq/rabbitmq.config ]]; then      cp -af /opt/kolla/rabbitmq/rabbitmq.config /etc/rabbitmq/rabbitmq.config      chown rabbitmq: /etc/rabbitmq/rabbitmq.config      chmod 0600 /etc/rabbitmq/rabbitmq.config if [[ -f /opt/kolla/rabbitmq/rabbitmq-env.conf ]]; then      cp -af /opt/kolla/rabbitmq/rabbitmq-env.conf /etc/rabbitmq/rabbitmq-env.conf      chown rabbitmq: /etc/rabbitmq/rabbitmq-env.conf      chmod 0600 /etc/rabbitmq/rabbitmq-env.conf fi kolla/docker_templates/glance/glance-api/config-external.sh: #!/bin/bash SOURCE="/opt/kolla/glance-api/glance-api.conf" TARGET="/etc/glance/glance-api.conf" OWNER="glance" if [[ -f "$SOURCE" ]]; then     cp $SOURCE $TARGET     chown ${OWNER}: $TARGET     chmod 0644 $TARGET fi I think it's better to use variables SOURCE and TARGET in config-external.sh to keep consistant with glance, so it will easy to modify it in future, and galera,keystone,swift have the same issue. The config-external.sh content in rabbitmq and glance is the different style,like follow: kolla/docker_templates/rabbitmq/config-external.sh: # Cluster configuration # Cluster configuration if [[ -f /opt/kolla/rabbitmq/rabbitmq.config ]]; then      cp -af /opt/kolla/rabbitmq/rabbitmq.config /etc/rabbitmq/rabbitmq.config      chown rabbitmq: /etc/rabbitmq/rabbitmq.config      chmod 0600 /etc/rabbitmq/rabbitmq.config if [[ -f /opt/kolla/rabbitmq/rabbitmq-env.conf ]]; then      cp -af /opt/kolla/rabbitmq/rabbitmq-env.conf /etc/rabbitmq/rabbitmq-env.conf      chown rabbitmq: /etc/rabbitmq/rabbitmq-env.conf      chmod 0600 /etc/rabbitmq/rabbitmq-env.conf fi kolla/docker_templates/glance/glance-api/config-external.sh: #!/bin/bash SOURCE="/opt/kolla/glance-api/glance-api.conf" TARGET="/etc/glance/glance-api.conf" OWNER="glance" if [[ -f "$SOURCE" ]]; then     cp $SOURCE $TARGET     chown ${OWNER}: $TARGET     chmod 0644 $TARGET fi I think it's better to use variables SOURCE and TARGET in config-external.sh to keep consistant with glance, so it will easy to modify it in future, and galera,keystone,swift have the same issue.
2015-08-17 18:05:20 XiaBing Yao kolla: assignee XiaBing Yao (yao3690093-o)
2015-08-17 18:19:03 OpenStack Infra kolla: status New In Progress
2015-08-17 18:29:39 Steven Dake kolla: importance Undecided Low
2015-08-17 18:29:42 Steven Dake kolla: milestone liberty-3
2015-08-18 07:19:05 OpenStack Infra kolla: status In Progress Fix Committed
2015-11-20 21:53:38 Sam Yaple kolla: status Fix Committed Fix Released