TechDebt: simplify list of excluded directories in bashate tox

Bug #1462801 reported by Steven Dake
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Invalid
Low
Unassigned

Bug Description

In tox.ini there is a command:

  bash -c "files=`egrep -rlI --exclude-dir .git --exclude-dir .tox '^[[:punct:]]+!/(bin/|/usr/bin/
env )(ba)?sh' .` && bashate $files"

It would be ideal if tox.ini could instead take something like

--exclude-dir={.git,.tox}

But this results in errors. Escaping with --exclude-dir=\{.git,.tox\} as recommended by the tox documentation also results in errors.

The error is:
    "substitution key %r not found" % key)
tox.ConfigError: ConfigError: substitution key '.git,.tox\\' not found

Steven Dake (sdake)
Changed in kolla:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Jeff Peeler (jpeeler-z) wrote :

I had difficulty using tox for regex quantifiers, which also uses brackets {}. Surely some form of escaping works though.

Revision history for this message
Steven Dake (sdake) wrote :

Agree should be possible. It isn't like I didn't try :) I am in a bit of a rush to finish the bashate gating tho and don't want to block on this detail. Hence the tracking as techdebt ;)

Steven Dake (sdake)
Changed in kolla:
milestone: none → liberty-rc1
Steven Dake (sdake)
Changed in kolla:
milestone: liberty-rc1 → liberty-rc2
Steven Dake (sdake)
Changed in kolla:
milestone: liberty-rc2 → liberty-rc3
Changed in kolla:
assignee: nobody → Michal Rostecki (mrostecki)
Steven Dake (sdake)
Changed in kolla:
milestone: liberty-rc3 → mitaka-1
Changed in kolla:
assignee: Michal Rostecki (mrostecki) → nobody
Changed in kolla:
assignee: nobody → Maciej Szankin (mszankin)
Steven Dake (sdake)
Changed in kolla:
milestone: mitaka-1 → mitaka-2
Steven Dake (sdake)
Changed in kolla:
milestone: mitaka-2 → mitaka-3
Steven Dake (sdake)
Changed in kolla:
milestone: mitaka-3 → mitaka-rc1
Steven Dake (sdake)
Changed in kolla:
milestone: mitaka-rc1 → mitaka-rc2
Revision history for this message
Steven Dake (sdake) wrote :

this is a low priority techdebt bug. Moving to newton 1.

Changed in kolla:
milestone: mitaka-rc2 → newton-1
importance: Wishlist → Low
Changed in kolla:
assignee: Maciej Szankin (mszankin) → nobody
Steven Dake (sdake)
Changed in kolla:
milestone: newton-1 → newton-2
Changed in kolla:
milestone: newton-2 → newton-3
Changed in kolla:
milestone: newton-3 → occata-1
Changed in kolla:
milestone: ocata-1 → ocata-2
Changed in kolla:
milestone: ocata-2 → ocata-3
Revision history for this message
Christian Berendt (berendt) wrote :

Closing as invalid. We now have a script called tools/run-bashate.sh. In the tox.ini we use "{toxinidir}/tools/run-bashate.sh".

Changed in kolla:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.