ansible library docker-compose error argument

[weiyu]

current docker-compose version is 1.3.0dev

ansible libary docker-compose passing the error argument detach and recreate to up(),This two argument is docker-compose 1.2.0rc4 used

TASK: [database | Bringing up mariadb service(s)] *****************************
<192.168.0.7> ESTABLISH CONNECTION FOR USER: root
<192.168.0.7> REMOTE_MODULE docker_compose command=up project_name=mariadb compose_file=/usr/share/kolla/compose/mariadb.yml
<192.168.0.7> EXEC sshpass -d7 ssh -C -tt -vvv -o ControlMaster=auto -o ControlPersist=60s -o ControlPath="/root/.ansible/cp/ansible-ssh-%h-%p-%r" -o GSSAPIAuthentication=no -o PubkeyAuthentication=no -o ConnectTimeout=10 192.168.0.7 /bin/sh -c 'mkdir -p $HOME/.ansible/tmp/ansible-tmp-1432351455.48-186292309317828 && echo $HOME/.ansible/tmp/ansible-tmp-1432351455.48-186292309317828'
<192.168.0.7> PUT /tmp/tmp3GDRzP TO /root/.ansible/tmp/ansible-tmp-1432351455.48-186292309317828/docker_compose
<192.168.0.7> EXEC sshpass -d7 ssh -C -tt -vvv -o ControlMaster=auto -o ControlPersist=60s -o ControlPath="/root/.ansible/cp/ansible-ssh-%h-%p-%r" -o GSSAPIAuthentication=no -o PubkeyAuthentication=no -o ConnectTimeout=10 192.168.0.7 /bin/sh -c 'LANG=C LC_CTYPE=C /usr/bin/python /root/.ansible/tmp/ansible-tmp-1432351455.48-186292309317828/docker_compose; rm -rf /root/.ansible/tmp/ansible-tmp-1432351455.48-186292309317828/ >/dev/null 2>&1'
failed: [192.168.0.7] => {"changed": true, "failed": true}
msg: TypeError("up() got an unexpected keyword argument 'detach'",)

FATAL: all hosts have already failed -- aborting

PLAY RECAP ********************************************************************
           to retry, use: --limit @/root/site.retry

kolla/ansible/library/docker-compose

203 def up(self):
204 self.project_contains = self.project.up(
205 detach = True, # erroe
206 do_build = not self.no_build,
207 insecure_registry = self.insecure_registry,
208 recreate = not self.no_recreate, #error
209 service_names = self.service_names,
210 start_deps = not self.no_deps,
211 )

[weiyu (weiyu)]

remove detach argument and no_recreate change to smart_recreate and allow_recreate
review https://review.openstack.org/#/c/187136/1

[OpenStack Infra (hudson-openstack)]

Change abandoned by weiyu (<email address hidden>) on branch: master
Review: https://review.openstack.org/187505
Reason: error change id

[weiyu (weiyu)]

this bug not abandoned, #2 is a wrong operation

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/187136
Committed: https://git.openstack.org/cgit/stackforge/kolla/commit/?id=0e00ad2188bb4534139b023dbc402c0278259a9e
Submitter: Jenkins
Branch: master

commit 0e00ad2188bb4534139b023dbc402c0278259a9e
Author: weiyu <email address hidden>
Date: Mon Jun 1 15:48:57 2015 +0800

    fix ansible libary passing error arguments.

    kolla is mandatory to run a version of docker-compose that
    includes pid: host support.docker-compose 1.3.0 to include the
    necessary features.

    docker-compose 1.3.0 project.up() abandoned the parameters
    detach and use allow_recreate replace recreate parameters.
    closes-Bug: #1458116

    Change-Id: I1235da58db5bedf208ebaea2a54568964dc802f8