Removing global variables

[ravig]

Can we remove some of the global variables like:

"KKR = service_resources.KollaKubernetesResources.Get()"

class _ServiceCommand(base_command.KollaKubernetesBaseCommand):

    _action = None # must be set in derived classes
    KKR = None

    # By defining init's here.
    def __init__(self):
        self.KKR = service_resources.KollaKubernetesResources.Get()

Any specific reason for having them? Am I missing anything here? If needed I can submit some code cleanup changes.

Thanks,
Ravi.

[Surya Prakash Singh (confisurya)]

hi ravig,

I think there is no need of removing this. I am not 100% sure but yes there can be a global function in future and that function can use *KKR* global variable too.
For it seems fine to me.