Galera nodes in Donor state are removed from haproxy backend list

Bug #1850945 reported by Mark Goddard
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Mark Goddard
Stein
Fix Committed
Medium
Radosław Piliszek
Train
Fix Released
Medium
Mark Goddard

Bug Description

We use the wsrep_notify.sh script to notify changes in Galera cluster membership to haproxy. When xtrabackup was used for the state transfer, nodes in the Donor state would be included in the backend pool. However, since the switch to mariabackup in the Stein cycle, we now remove nodes in the Donor state from the backend pool, due to the following line in the script:

[[ $SST_METHOD =~ 'xtrabackup' ]] && CMD=$ENABLE_LB || CMD=$DISABLE_LB

The sst_method is now mariabackup, so we will execute the command to disable the load balancer for this node.

https://galeracluster.com/library/documentation/mysql-wsrep-options.html#wsrep-notify-cmd

Mark Goddard (mgoddard)
Changed in kolla-ansible:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/692567

Changed in kolla-ansible:
assignee: nobody → Mark Goddard (mgoddard)
status: Triaged → In Progress
Changed in kolla-ansible:
assignee: Mark Goddard (mgoddard) → Radosław Piliszek (yoctozepto)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/692567
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=f6e8478b6112a6a4820ce8ed867a5a05b16d9bf0
Submitter: Zuul
Branch: master

commit f6e8478b6112a6a4820ce8ed867a5a05b16d9bf0
Author: Mark Goddard <email address hidden>
Date: Fri Nov 1 15:17:48 2019 +0000

    Enable load balancing to Galera nodes in Donor state

    We use the wsrep_notify.sh script to notify changes in Galera cluster
    membership to haproxy. When xtrabackup was used for the state transfer,
    nodes in the Donor state would be included in the backend pool. However,
    since the switch to mariabackup in the Stein cycle, we now remove nodes
    in the Donor state from the backend pool.

    This change ensures that nodes in the Donor state are included in the
    backend pool when the SST method is either xtrabackup or mariabackup.

    https://galeracluster.com/library/documentation/mysql-wsrep-options.html#wsrep-notify-cmd

    Change-Id: Ide4301779a0d221ae5d4dbdd4873fb8a40eb7297
    Co-authored-by: Radosław Piliszek <email address hidden>
    Closes-Bug: #1850945

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 9.0.0.0rc1

This issue was fixed in the openstack/kolla-ansible 9.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/701343

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/stein)

Reviewed: https://review.opendev.org/701343
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=1b89068bb6092ea2d3bdac3d0282b0df1cb6e2ce
Submitter: Zuul
Branch: stable/stein

commit 1b89068bb6092ea2d3bdac3d0282b0df1cb6e2ce
Author: Mark Goddard <email address hidden>
Date: Fri Nov 1 15:17:48 2019 +0000

    Enable load balancing to Galera nodes in Donor state

    We use the wsrep_notify.sh script to notify changes in Galera cluster
    membership to haproxy. When xtrabackup was used for the state transfer,
    nodes in the Donor state would be included in the backend pool. However,
    since the switch to mariabackup in the Stein cycle, we now remove nodes
    in the Donor state from the backend pool.

    This change ensures that nodes in the Donor state are included in the
    backend pool when the SST method is either xtrabackup or mariabackup.

    https://galeracluster.com/library/documentation/mysql-wsrep-options.html#wsrep-notify-cmd

    Change-Id: Ide4301779a0d221ae5d4dbdd4873fb8a40eb7297
    Co-authored-by: Radosław Piliszek <email address hidden>
    Closes-Bug: #1850945
    (cherry picked from commit f6e8478b6112a6a4820ce8ed867a5a05b16d9bf0)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 8.1.0

This issue was fixed in the openstack/kolla-ansible 8.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.