Keystone admin endpoint recreated during upgrade

[Mark Goddard]

In the Zed release kolla-ansible stopped creating the Keystone admin endpoint by default. Operators were instructed to remove the endpoint manually or set keystone_create_admin_endpoint to keep it during Zed.

The following condition was used to determine whether to create an admin endpoint:

  kolla_action == 'upgrade' or keystone_create_admin_endpoint | bool

This was intended to be removed in Antelope, but remained in the code until removed [1] during the Caracal cycle. This means that if an operator removes the admin endpoint after upgrading to Zed, Kolla Ansible will recreate it when upgrading to Antelope or Bobcat.

[1] https://review.opendev.org/c/openstack/kolla-ansible/+/904396

[Mark Goddard (mgoddard)]

https://review.opendev.org/c/openstack/kolla-ansible/+/904724

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/904724
Committed: https://opendev.org/openstack/kolla-ansible/commit/1b6c1cb3dbca39185dd2e76b907c26ce7d3aa12e
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 1b6c1cb3dbca39185dd2e76b907c26ce7d3aa12e
Author: Michal Nasiadka <email address hidden>
Date: Thu Dec 28 09:39:05 2023 +0100

    post-2023.1: Remove keystone admin endpoint bits

    This backport has been updated to include explicit removal of the admin
    endpoint, and should be applied to both Bobcat and Antelope.

    In the Zed release kolla-ansible stopped creating the Keystone admin
    endpoint by default. Operators were instructed to remove the endpoint
    manually or set keystone_create_admin_endpoint to keep it during Zed.

    The following condition was used to determine whether to create an admin
    endpoint:

      kolla_action == 'upgrade' or keystone_create_admin_endpoint | bool

    This was intended to be removed in Antelope, but remained in the code
    until removed [1] during the Caracal cycle. This means that if an
    operator removes the admin endpoint after upgrading to Zed, Kolla
    Ansible will recreate it when upgrading to Antelope or Bobcat.

    [1] https://review.opendev.org/c/openstack/kolla-ansible/+/904396

    Closes-Bug: #2052298
    Change-Id: I27028ffae26a57d510e1a78c38ead2f925396e81
    (cherry picked from commit 982c4d5e5f9d0dadefaf10c863fb520b47c46930)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/915803

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/915803
Committed: https://opendev.org/openstack/kolla-ansible/commit/4d7caa209cdbdb6082191613e4b0dfe028121580
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 4d7caa209cdbdb6082191613e4b0dfe028121580
Author: Michal Nasiadka <email address hidden>
Date: Thu Dec 28 09:39:05 2023 +0100

    post-2023.1: Remove keystone admin endpoint bits

    This backport has been updated to include explicit removal of the admin
    endpoint, and should be applied to both Bobcat and Antelope.

    In the Zed release kolla-ansible stopped creating the Keystone admin
    endpoint by default. Operators were instructed to remove the endpoint
    manually or set keystone_create_admin_endpoint to keep it during Zed.

    The following condition was used to determine whether to create an admin
    endpoint:

      kolla_action == 'upgrade' or keystone_create_admin_endpoint | bool

    This was intended to be removed in Antelope, but remained in the code
    until removed [1] during the Caracal cycle. This means that if an
    operator removes the admin endpoint after upgrading to Zed, Kolla
    Ansible will recreate it when upgrading to Antelope or Bobcat.

    [1] https://review.opendev.org/c/openstack/kolla-ansible/+/904396

    Closes-Bug: #2052298
    Change-Id: I27028ffae26a57d510e1a78c38ead2f925396e81
    (cherry picked from commit 982c4d5e5f9d0dadefaf10c863fb520b47c46930)
    (cherry picked from commit 1b6c1cb3dbca39185dd2e76b907c26ce7d3aa12e)