kolla-ansible

prechecks not passing for api_interfaces with dashes

Bug #2070051 reported by Michal Nasiadka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kayobe
Fix Released
Undecided
Unassigned
kolla-ansible
Status tracked in Dalmatian
Antelope
Fix Released
Medium
Unassigned
Bobcat
Fix Released
Medium
Unassigned
Caracal
Fix Committed
Medium
Unassigned
Dalmatian
Fix Released
Medium
Michal Nasiadka

Bug Description

Both port prechecks and load balancer role prechecks are failing on checking active interface when interface name is with dashes e.g. my-fantastic-interface-name - ansible does replace dashes with underscores under ansible_facts (but not for the interface list under ansible_facts.interfaces)

See original description
Revision history for this message
Michal Nasiadka (mnasiadka) wrote (last edit ):

In addition to that Kayobe is templating api and external interface with underscores instead of dashes to Kolla-Ansible and it shouldn't.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kayobe/+/922480

Changed in kolla-ansible:
status: New → In Progress
Changed in kayobe:
status: New → In Progress
Michal Nasiadka (mnasiadka)
description: updated
Revision history for this message
Doug Szumski (dszumski) wrote :

You could argue that this is a feature since we warn against using dashes in the documentation.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/922478
Committed: https://opendev.org/openstack/kolla-ansible/commit/a535e65a85aa99af2e42a22a891de79a172bd033
Submitter: "Zuul (22348)"
Branch: master

commit a535e65a85aa99af2e42a22a891de79a172bd033
Author: Michal Nasiadka <email address hidden>
Date: Fri Jun 21 16:39:09 2024 +0200

    Fix prechecks for interfaces with dashes

    Closes-Bug: #2070051

    Depends-On: https://review.opendev.org/c/openstack/ansible-collection-kolla/+/923544

    Change-Id: I221eb136e77c61aef39e8646b48b927352d1419d

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/2024.1)

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/923958

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/923959

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/923960

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/923959
Committed: https://opendev.org/openstack/kolla-ansible/commit/54019c56f12856ad1c87fac927a02b27a413ef70
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 54019c56f12856ad1c87fac927a02b27a413ef70
Author: Michal Nasiadka <email address hidden>
Date: Fri Jun 21 16:39:09 2024 +0200

    Fix prechecks for interfaces with dashes

    Closes-Bug: #2070051

    Depends-On: https://review.opendev.org/c/openstack/ansible-collection-kolla/+/923544

    Change-Id: I221eb136e77c61aef39e8646b48b927352d1419d
    (cherry picked from commit a535e65a85aa99af2e42a22a891de79a172bd033)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/923960
Committed: https://opendev.org/openstack/kolla-ansible/commit/f78dab4bd742648e9c525d68fe80539a3f076eab
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit f78dab4bd742648e9c525d68fe80539a3f076eab
Author: Michal Nasiadka <email address hidden>
Date: Fri Jun 21 16:39:09 2024 +0200

    Fix prechecks for interfaces with dashes

    Closes-Bug: #2070051

    Depends-On: https://review.opendev.org/c/openstack/ansible-collection-kolla/+/923544

    Change-Id: I221eb136e77c61aef39e8646b48b927352d1419d
    (cherry picked from commit a535e65a85aa99af2e42a22a891de79a172bd033)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (master)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/922480
Committed: https://opendev.org/openstack/kayobe/commit/f2b042dcec55860bd7c57ca6c8db9e9a9580bab7
Submitter: "Zuul (22348)"
Branch: master

commit f2b042dcec55860bd7c57ca6c8db9e9a9580bab7
Author: Michal Nasiadka <email address hidden>
Date: Fri Jun 21 16:50:32 2024 +0200

    Stop replacing dashes with underscores for Kolla interfaces

    This also removes test__run_one_with_dashes, because it's not needed
    anymore.

    Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/922478
    Closes-Bug: #2070051
    Change-Id: Ia11ac49986e2bebba17e533232d8cfd116ba9e73

Changed in kayobe:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/2024.1)

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/kayobe/+/925390

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/kayobe/+/925391

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/kayobe/+/925392

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 16.6.0

This issue was fixed in the openstack/kolla-ansible 16.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 17.4.0

This issue was fixed in the openstack/kolla-ansible 17.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/2024.1)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/925390
Committed: https://opendev.org/openstack/kayobe/commit/c866ceb2f881e76e9142f51d89d919233e4dc47a
Submitter: "Zuul (22348)"
Branch: stable/2024.1

commit c866ceb2f881e76e9142f51d89d919233e4dc47a
Author: Michal Nasiadka <email address hidden>
Date: Fri Jun 21 16:50:32 2024 +0200

    Stop replacing dashes with underscores for Kolla interfaces

    This also removes test__run_one_with_dashes, because it's not needed
    anymore.

    Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/922478
    Closes-Bug: #2070051
    Change-Id: Ia11ac49986e2bebba17e533232d8cfd116ba9e73
    (cherry picked from commit f2b042dcec55860bd7c57ca6c8db9e9a9580bab7)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/925391
Committed: https://opendev.org/openstack/kayobe/commit/abf7b2938e201672fe569b8520b601018ece9605
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit abf7b2938e201672fe569b8520b601018ece9605
Author: Michal Nasiadka <email address hidden>
Date: Fri Jun 21 16:50:32 2024 +0200

    Stop replacing dashes with underscores for Kolla interfaces

    This also removes test__run_one_with_dashes, because it's not needed
    anymore.

    Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/922478
    Closes-Bug: #2070051
    Change-Id: Ia11ac49986e2bebba17e533232d8cfd116ba9e73
    (cherry picked from commit f2b042dcec55860bd7c57ca6c8db9e9a9580bab7)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/925392
Committed: https://opendev.org/openstack/kayobe/commit/ff60f19a7fa66b18f04e7eee38a7208fd5ddb639
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit ff60f19a7fa66b18f04e7eee38a7208fd5ddb639
Author: Michal Nasiadka <email address hidden>
Date: Fri Jun 21 16:50:32 2024 +0200

    Stop replacing dashes with underscores for Kolla interfaces

    This also removes test__run_one_with_dashes, because it's not needed
    anymore.

    Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/922478
    Closes-Bug: #2070051
    Change-Id: Ia11ac49986e2bebba17e533232d8cfd116ba9e73
    (cherry picked from commit f2b042dcec55860bd7c57ca6c8db9e9a9580bab7)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/2024.1)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/923958
Committed: https://opendev.org/openstack/kolla-ansible/commit/d090164bb272fc6c681b381ff47edb3edfb61dc7
Submitter: "Zuul (22348)"
Branch: stable/2024.1

commit d090164bb272fc6c681b381ff47edb3edfb61dc7
Author: Michal Nasiadka <email address hidden>
Date: Fri Jun 21 16:39:09 2024 +0200

    Fix prechecks for interfaces with dashes

    Closes-Bug: #2070051

    Depends-On: https://review.opendev.org/c/openstack/ansible-collection-kolla/+/923544

    Change-Id: I221eb136e77c61aef39e8646b48b927352d1419d
    (cherry picked from commit a535e65a85aa99af2e42a22a891de79a172bd033)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.