Mariadb upgrade not working when using check mode

Bug #2052501 reported by Michal Arbet
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Status tracked in Caracal
Antelope
Fix Released
Medium
Unassigned
Bobcat
Fix Released
Medium
Unassigned
Caracal
Fix Released
Medium
Michal Arbet
Zed
Fix Released
Medium
Unassigned

Bug Description

HI,

We have a bug in kolla-ansible mariadb upgrade when using check mode

kolla-ansible upgrade --check --diff

TASK [mariadb : Flush handlers] ***********************************************************************************************************************************************************************************

RUNNING HANDLER [mariadb : Restart MariaDB on existing cluster members] *******************************************************************************************************************************************
skipping: [controller0] => (item=1)
skipping: [controller0] => (item=2)
skipping: [controller1] => (item=0)
skipping: [controller0] => (item=3)
skipping: [controller1] => (item=2)
skipping: [controller2] => (item=0)
skipping: [controller1] => (item=3)
skipping: [controller2] => (item=1)
skipping: [controller2] => (item=3)
included: /opt/kolla-ansible/ansible/roles/mariadb/tasks/restart_services.yml for controller0

RUNNING HANDLER [mariadb : Restart MariaDB container] *************************************************************************************************************************************************************
skipping: [controller0]

RUNNING HANDLER [mariadb : Wait for MariaDB service port liveness] ************************************************************************************************************************************************
skipping: [controller0]

RUNNING HANDLER [mariadb : Wait for MariaDB service to sync WSREP] ************************************************************************************************************************************************
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (10 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (9 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (8 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (7 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (6 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (5 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (4 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (3 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (2 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (1 retries left).
fatal: [controller0]: FAILED! => {"attempts": 10, "censored": "the output has been hidden due to the fact that 'no_log: true' was specified for this result", "changed": true}
included: /opt/kolla-ansible/ansible/roles/mariadb/tasks/restart_services.yml for controller1 => (item=1)

RUNNING HANDLER [mariadb : Restart MariaDB container] *************************************************************************************************************************************************************
skipping: [controller1]

RUNNING HANDLER [mariadb : Wait for MariaDB service port liveness] ************************************************************************************************************************************************
skipping: [controller1]

RUNNING HANDLER [mariadb : Wait for MariaDB service to sync WSREP] ************************************************************************************************************************************************
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (10 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (9 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (8 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (7 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (6 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (5 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (4 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (3 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (2 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (1 retries left).
fatal: [controller1]: FAILED! => {"attempts": 10, "censored": "the output has been hidden due to the fact that 'no_log: true' was specified for this result", "changed": true}
included: /opt/kolla-ansible/ansible/roles/mariadb/tasks/restart_services.yml for controller2 => (item=2)

RUNNING HANDLER [mariadb : Restart MariaDB container] *************************************************************************************************************************************************************
skipping: [controller2]

RUNNING HANDLER [mariadb : Wait for MariaDB service port liveness] ************************************************************************************************************************************************
skipping: [controller2]

RUNNING HANDLER [mariadb : Wait for MariaDB service to sync WSREP] ************************************************************************************************************************************************
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (10 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (9 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (8 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (7 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (6 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (5 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (4 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (3 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (2 retries left).
FAILED - RETRYING: Wait for MariaDB service to sync WSREP (1 retries left).
fatal: [controller2]: FAILED! => {"attempts": 10, "censored": "the output has been hidden due to the fact that 'no_log: true' was specified for this result", "changed": true}

RUNNING HANDLER [mariadb : Start MariaDB on new nodes] ************************************************************************************************************************************************************

summary: - Mariadb upgade not working when using check mode
+ Mariadb,rabbitmq upgrade not working when using check mode
description: updated
description: updated
summary: - Mariadb,rabbitmq upgrade not working when using check mode
+ Mariadb upgrade not working when using check mode
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)
Changed in kolla-ansible:
status: New → In Progress
Changed in kolla-ansible:
assignee: nobody → Michal Arbet (michalarbet)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/907971
Committed: https://opendev.org/openstack/kolla-ansible/commit/d0b93a631dec21e77ae095eea46dbd5c5ffd789c
Submitter: "Zuul (22348)"
Branch: master

commit d0b93a631dec21e77ae095eea46dbd5c5ffd789c
Author: Michal Arbet <email address hidden>
Date: Tue Feb 6 10:30:38 2024 +0100

    Fix mariadb role when used with check mode

    This patch adds check_mode: false to tasks
    in restart_services.yml which just checking
    some WSREP status and if port is UP.

    Closes-Bug: #2052501
    Change-Id: I92a591900d85138a87991a18dd4339efd053ef1b

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/909095

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/909096

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/909097

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/909096
Committed: https://opendev.org/openstack/kolla-ansible/commit/8f5f3867c995af6d013cd3969df0c4edeffb6130
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 8f5f3867c995af6d013cd3969df0c4edeffb6130
Author: Michal Arbet <email address hidden>
Date: Tue Feb 6 10:30:38 2024 +0100

    Fix mariadb role when used with check mode

    This patch adds check_mode: false to tasks
    in restart_services.yml which just checking
    some WSREP status and if port is UP.

    Closes-Bug: #2052501
    Change-Id: I92a591900d85138a87991a18dd4339efd053ef1b
    (cherry picked from commit d0b93a631dec21e77ae095eea46dbd5c5ffd789c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/909097
Committed: https://opendev.org/openstack/kolla-ansible/commit/9a3f444860da86d7df1ac9d52317cad01869d560
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 9a3f444860da86d7df1ac9d52317cad01869d560
Author: Michal Arbet <email address hidden>
Date: Tue Feb 6 10:30:38 2024 +0100

    Fix mariadb role when used with check mode

    This patch adds check_mode: false to tasks
    in restart_services.yml which just checking
    some WSREP status and if port is UP.

    Closes-Bug: #2052501
    Change-Id: I92a591900d85138a87991a18dd4339efd053ef1b
    (cherry picked from commit d0b93a631dec21e77ae095eea46dbd5c5ffd789c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/909095
Committed: https://opendev.org/openstack/kolla-ansible/commit/73c3ca99f7b07f286b4384772224a5e1472182f1
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 73c3ca99f7b07f286b4384772224a5e1472182f1
Author: Michal Arbet <email address hidden>
Date: Tue Feb 6 10:30:38 2024 +0100

    Fix mariadb role when used with check mode

    This patch adds check_mode: false to tasks
    in restart_services.yml which just checking
    some WSREP status and if port is UP.

    Closes-Bug: #2052501
    Change-Id: I92a591900d85138a87991a18dd4339efd053ef1b
    (cherry picked from commit d0b93a631dec21e77ae095eea46dbd5c5ffd789c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 16.5.0

This issue was fixed in the openstack/kolla-ansible 16.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 17.3.0

This issue was fixed in the openstack/kolla-ansible 17.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 15.6.0

This issue was fixed in the openstack/kolla-ansible 15.6.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.