kolla-ansible

Prechecks fail in check mode

Bug #2002657 reported by Mark Goddard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Unassigned
Wallaby
Fix Released
Undecided
Unassigned
Xena
Fix Released
Undecided
Unassigned
Yoga
Fix Released
Undecided
Unassigned
Zed
Fix Released
Undecided
Unassigned

Bug Description

# Steps to reproduce

On a deployed cloud, run prechecks in Ansible check mode:

  kolla-ansible prechecks --check

# Expected results

Prechecks pass.

# Actual results

Some prechecks fail because they use the command module which is silently not run in check mode.
Other prechecks do not run correctly in check mode due to e.g. looking for a string in empty command output or not querying which containers are running.

The first check to fail is the time sync check, and claims that the system clock is not synced (even if it is):

timedatectl sees the system clock as unsynchronized. Please wait for synchronization. Alternatively, set 'prechecks_enable_host_ntp_checks' to 'false' to disable this check if your NTP daemon is not recognised by 'timedatectl status'.

See original description
Mark Goddard (mgoddard)
Changed in kolla-ansible:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/869988

Changed in kolla-ansible:
status: Triaged → In Progress
Mark Goddard (mgoddard)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/869988
Committed: https://opendev.org/openstack/kolla-ansible/commit/46aeb9843f3702f7300dc8627d98a7af8d24cfb1
Submitter: "Zuul (22348)"
Branch: master

commit 46aeb9843f3702f7300dc8627d98a7af8d24cfb1
Author: Mark Goddard <email address hidden>
Date: Wed Jan 11 16:04:55 2023 +0000

    Fix prechecks in check mode

    When running in check mode, some prechecks previously failed because
    they use the command module which is silently not run in check mode.
    Other prechecks were not running correctly in check mode due to e.g.
    looking for a string in empty command output or not querying which
    containers are running.

    This change fixes these issues.

    Closes-Bug: #2002657
    Change-Id: I5219cb42c48d5444943a2d48106dc338aa08fa7c

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/870773

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/870774

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/870775

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/870776

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/870773
Committed: https://opendev.org/openstack/kolla-ansible/commit/3eb9bb586fae220ea0267be22e9d3ca7d2d3e8df
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 3eb9bb586fae220ea0267be22e9d3ca7d2d3e8df
Author: Mark Goddard <email address hidden>
Date: Wed Jan 11 16:04:55 2023 +0000

    Fix prechecks in check mode

    When running in check mode, some prechecks previously failed because
    they use the command module which is silently not run in check mode.
    Other prechecks were not running correctly in check mode due to e.g.
    looking for a string in empty command output or not querying which
    containers are running.

    This change fixes these issues.

    Closes-Bug: #2002657
    Change-Id: I5219cb42c48d5444943a2d48106dc338aa08fa7c
    (cherry picked from commit 46aeb9843f3702f7300dc8627d98a7af8d24cfb1)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/870775
Committed: https://opendev.org/openstack/kolla-ansible/commit/e690cb4dc7360cff99f9e8e2a40a8e324566c19b
Submitter: "Zuul (22348)"
Branch: stable/xena

commit e690cb4dc7360cff99f9e8e2a40a8e324566c19b
Author: Mark Goddard <email address hidden>
Date: Wed Jan 11 16:04:55 2023 +0000

    Fix prechecks in check mode

    When running in check mode, some prechecks previously failed because
    they use the command module which is silently not run in check mode.
    Other prechecks were not running correctly in check mode due to e.g.
    looking for a string in empty command output or not querying which
    containers are running.

    This change fixes these issues.

    Closes-Bug: #2002657
    Change-Id: I5219cb42c48d5444943a2d48106dc338aa08fa7c
    (cherry picked from commit 46aeb9843f3702f7300dc8627d98a7af8d24cfb1)

tags: added: in-stable-xena
tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/870774
Committed: https://opendev.org/openstack/kolla-ansible/commit/afc999945ce8dad12f51788de9202b7f76313c4d
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit afc999945ce8dad12f51788de9202b7f76313c4d
Author: Mark Goddard <email address hidden>
Date: Wed Jan 11 16:04:55 2023 +0000

    Fix prechecks in check mode

    When running in check mode, some prechecks previously failed because
    they use the command module which is silently not run in check mode.
    Other prechecks were not running correctly in check mode due to e.g.
    looking for a string in empty command output or not querying which
    containers are running.

    This change fixes these issues.

    Closes-Bug: #2002657
    Change-Id: I5219cb42c48d5444943a2d48106dc338aa08fa7c
    (cherry picked from commit 46aeb9843f3702f7300dc8627d98a7af8d24cfb1)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/870776
Committed: https://opendev.org/openstack/kolla-ansible/commit/8badcadd334a4744e3e9255d6dcab6e7228e42ab
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 8badcadd334a4744e3e9255d6dcab6e7228e42ab
Author: Mark Goddard <email address hidden>
Date: Wed Jan 11 16:04:55 2023 +0000

    Fix prechecks in check mode

    When running in check mode, some prechecks previously failed because
    they use the command module which is silently not run in check mode.
    Other prechecks were not running correctly in check mode due to e.g.
    looking for a string in empty command output or not querying which
    containers are running.

    This change fixes these issues.

    Closes-Bug: #2002657
    Change-Id: I5219cb42c48d5444943a2d48106dc338aa08fa7c
    (cherry picked from commit 46aeb9843f3702f7300dc8627d98a7af8d24cfb1)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 13.8.0

This issue was fixed in the openstack/kolla-ansible 13.8.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 14.8.0

This issue was fixed in the openstack/kolla-ansible 14.8.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 15.1.0

This issue was fixed in the openstack/kolla-ansible 15.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to kolla-ansible (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/880860

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/880860
Committed: https://opendev.org/openstack/kolla-ansible/commit/e0191cb167ffb019472d00560e80da8ce45033d4
Submitter: "Zuul (22348)"
Branch: master

commit e0191cb167ffb019472d00560e80da8ce45033d4
Author: Matt Crees <email address hidden>
Date: Wed Apr 19 16:19:59 2023 +0100

    Add check_mode: false to Nova upgrade checks

    The step "Run Nova upgrade checks" needs to be excluded from check mode.

    Related-Bug: #2002657
    Change-Id: Ida582606b03d1896a6c58d4b324d088dc3b71852

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to kolla-ansible (stable/zed)

Related fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/881327

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 16.0.0.0rc1

This issue was fixed in the openstack/kolla-ansible 16.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible wallaby-eol

This issue was fixed in the openstack/kolla-ansible wallaby-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to kolla-ansible (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/881327
Committed: https://opendev.org/openstack/kolla-ansible/commit/f72b4955be6d073358c91681b71173d7a02e8c0a
Submitter: "Zuul (22348)"
Branch: stable/zed

commit f72b4955be6d073358c91681b71173d7a02e8c0a
Author: Matt Crees <email address hidden>
Date: Wed Apr 19 16:19:59 2023 +0100

    Add check_mode: false to Nova upgrade checks

    The step "Run Nova upgrade checks" needs to be excluded from check mode.

    Related-Bug: #2002657
    Change-Id: Ida582606b03d1896a6c58d4b324d088dc3b71852
    (cherry picked from commit e0191cb167ffb019472d00560e80da8ce45033d4)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.