Node Exporter reports wrong file system metrics

Bug #1961438 reported by Pierre Riteau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Undecided
Unassigned

Bug Description

Node Exporter reports the same values for all node_filesystem_* metrics of a host, even though multiple file systems are mounted.

See the Node Exporter documentation for a configuration that fixes this issue: https://github.com/prometheus/node_exporter#docker

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)
Changed in kolla-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/829973
Committed: https://opendev.org/openstack/kolla-ansible/commit/b210dcd6e2f9c36a71d20f40939660aa5b538144
Submitter: "Zuul (22348)"
Branch: master

commit b210dcd6e2f9c36a71d20f40939660aa5b538144
Author: Pierre Riteau <email address hidden>
Date: Fri Feb 18 18:36:22 2022 +0100

    Configure node-exporter to report correct file system metrics

    Without this configuration, all mount points are reporting the same
    utilisation metrics [1]. With the rslave option, all root mounts from
    the host are visible in the container, so we can remove the bind mounts
    for /proc and /sys.

    [1] https://github.com/prometheus/node_exporter#docker

    Change-Id: I4087dc81f9d1fa5daa24b9df6daf1f9e1ccd702f
    Closes-Bug: #1961438

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/830141

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/830142

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/830143

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/830144

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/830141
Committed: https://opendev.org/openstack/kolla-ansible/commit/b4f68a99109ec0023670499ca204a385dd8d8b88
Submitter: "Zuul (22348)"
Branch: stable/xena

commit b4f68a99109ec0023670499ca204a385dd8d8b88
Author: Pierre Riteau <email address hidden>
Date: Fri Feb 18 18:36:22 2022 +0100

    Configure node-exporter to report correct file system metrics

    Without this configuration, all mount points are reporting the same
    utilisation metrics [1]. With the rslave option, all root mounts from
    the host are visible in the container, so we can remove the bind mounts
    for /proc and /sys.

    [1] https://github.com/prometheus/node_exporter#docker

    Change-Id: I4087dc81f9d1fa5daa24b9df6daf1f9e1ccd702f
    Closes-Bug: #1961438
    (cherry picked from commit b210dcd6e2f9c36a71d20f40939660aa5b538144)

tags: added: in-stable-xena
tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/830142
Committed: https://opendev.org/openstack/kolla-ansible/commit/ae46e80f3ebb194425e12816c17bee525a3f41a1
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit ae46e80f3ebb194425e12816c17bee525a3f41a1
Author: Pierre Riteau <email address hidden>
Date: Fri Feb 18 18:36:22 2022 +0100

    Configure node-exporter to report correct file system metrics

    Without this configuration, all mount points are reporting the same
    utilisation metrics [1]. With the rslave option, all root mounts from
    the host are visible in the container, so we can remove the bind mounts
    for /proc and /sys.

    [1] https://github.com/prometheus/node_exporter#docker

    Change-Id: I4087dc81f9d1fa5daa24b9df6daf1f9e1ccd702f
    Closes-Bug: #1961438
    (cherry picked from commit b210dcd6e2f9c36a71d20f40939660aa5b538144)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/830143
Committed: https://opendev.org/openstack/kolla-ansible/commit/e4f93a60ac48daaa0a9bc77706af09fe2ae584d5
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit e4f93a60ac48daaa0a9bc77706af09fe2ae584d5
Author: Pierre Riteau <email address hidden>
Date: Fri Feb 18 18:36:22 2022 +0100

    Configure node-exporter to report correct file system metrics

    Without this configuration, all mount points are reporting the same
    utilisation metrics [1]. With the rslave option, all root mounts from
    the host are visible in the container, so we can remove the bind mounts
    for /proc and /sys.

    [1] https://github.com/prometheus/node_exporter#docker

    Change-Id: I4087dc81f9d1fa5daa24b9df6daf1f9e1ccd702f
    Closes-Bug: #1961438
    (cherry picked from commit b210dcd6e2f9c36a71d20f40939660aa5b538144)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/830144
Committed: https://opendev.org/openstack/kolla-ansible/commit/14f160a61c929099abab32dce531e0ec2795a8dd
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 14f160a61c929099abab32dce531e0ec2795a8dd
Author: Pierre Riteau <email address hidden>
Date: Fri Feb 18 18:36:22 2022 +0100

    Configure node-exporter to report correct file system metrics

    Without this configuration, all mount points are reporting the same
    utilisation metrics [1]. With the rslave option, all root mounts from
    the host are visible in the container, so we can remove the bind mounts
    for /proc and /sys.

    [1] https://github.com/prometheus/node_exporter#docker

    Change-Id: I4087dc81f9d1fa5daa24b9df6daf1f9e1ccd702f
    Closes-Bug: #1961438
    (cherry picked from commit b210dcd6e2f9c36a71d20f40939660aa5b538144)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 14.0.0.0rc1

This issue was fixed in the openstack/kolla-ansible 14.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 11.4.0

This issue was fixed in the openstack/kolla-ansible 11.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 12.4.0

This issue was fixed in the openstack/kolla-ansible 12.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 13.1.0

This issue was fixed in the openstack/kolla-ansible 13.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible ussuri-eol

This issue was fixed in the openstack/kolla-ansible ussuri-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.